Skip to content

Commit 7187fda

Browse files
committed
backprt dropping empty expose events to reddit_experiments & use info logger
1 parent 5e0a0de commit 7187fda

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

reddit_decider/__init__.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -388,16 +388,16 @@ def expose(
388388
to :code:`events_logger` (keys must be part of v2 event schema,
389389
use dicts for nested fields) under :code:`inputs` and as :code:`kwargs`
390390
"""
391-
decider = self._get_decider()
392-
if decider is None:
393-
return
394-
395391
if variant_name is None or variant_name == "":
396-
logger.warning(
397-
f"`variant_name` not provided in expose() call for experiment: {experiment_name}"
392+
logger.info(
393+
f"`variant_name` arg not provided in reddit_decider.expose() call for experiment: {experiment_name}"
398394
)
399395
return
400396

397+
decider = self._get_decider()
398+
if decider is None:
399+
return
400+
401401
experiment = decider.get_experiment(experiment_name)
402402
error = experiment.err()
403403
if error:

reddit_experiments/__init__.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -301,6 +301,12 @@ def expose(
301301
:param kwargs: Additional arguments that will be passed to logger.
302302
303303
"""
304+
if variant_name is None or variant_name == "":
305+
logger.info(
306+
f"`variant_name` arg not provided in reddit_experiments.expose() call for experiment: {experiment_name}"
307+
)
308+
return
309+
304310
experiment = self._get_experiment(experiment_name)
305311

306312
if experiment is None:

0 commit comments

Comments
 (0)