Skip to content

Commit 9ba1854

Browse files
committed
remove logger for variantless expose
1 parent e39ba93 commit 9ba1854

File tree

4 files changed

+2
-22
lines changed

4 files changed

+2
-22
lines changed

reddit_decider/__init__.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -389,9 +389,6 @@ def expose(
389389
use dicts for nested fields) under :code:`inputs` and as :code:`kwargs`
390390
"""
391391
if variant_name is None or variant_name == "":
392-
logger.info(
393-
f"`variant_name` arg not provided in reddit_decider.expose() call for experiment: {experiment_name}"
394-
)
395392
return
396393

397394
decider = self._get_decider()

reddit_experiments/__init__.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -302,9 +302,6 @@ def expose(
302302
303303
"""
304304
if variant_name is None or variant_name == "":
305-
logger.info(
306-
f"`variant_name` arg not provided in reddit_experiments.expose() call for experiment: {experiment_name}"
307-
)
308305
return
309306

310307
experiment = self._get_experiment(experiment_name)

tests/decider_tests.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -755,14 +755,7 @@ def test_expose_without_variant_name(self):
755755

756756
self.assertEqual(self.event_logger.log.call_count, 0)
757757

758-
with self.assertLogs() as captured:
759-
decider.expose("exp_1", None)
760-
761-
assert any(
762-
"`variant_name` arg not provided in reddit_decider.expose() call for experiment: exp_1"
763-
in x.getMessage()
764-
for x in captured.records
765-
)
758+
decider.expose("exp_1", None)
766759

767760
# exposure assertions
768761
self.assertEqual(self.event_logger.log.call_count, 0)

tests/experiment_tests.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -287,14 +287,7 @@ def test_expose_without_variant_name(self):
287287

288288
self.assertEqual(self.event_logger.log.call_count, 0)
289289

290-
with self.assertLogs() as captured:
291-
experiments.expose("test", variant_name=None, user=self.user, app_name="r2")
292-
293-
assert any(
294-
"`variant_name` arg not provided in reddit_experiments.expose() call for experiment: test"
295-
in x.getMessage()
296-
for x in captured.records
297-
)
290+
experiments.expose("test", variant_name=None, user=self.user, app_name="r2")
298291

299292
self.assertEqual(self.event_logger.log.call_count, 0)
300293

0 commit comments

Comments
 (0)