Merge pull request #60 from reddit/compare_decider_against_old_sdk

Compare `decider.get_variant()` against old sdk's `experiments.variant()`

Author: mrlevitas

reddit_decider/__init__.py

@@ -820,7 +820,7 @@ def get_all_dynamic_configs(self) -> List[Dict[str, Any]]:
         where "type" field can be one of:
             "boolean", "integer", "float", "string", or "map"
 
-        Dynamic Configurations that are malformed, fail parsing, or otherwirse
+        Dynamic Configurations that are malformed, fail parsing, or otherwise
         error for any reason are included in the response and have their respective default
         values set:
             "boolean" -> False

tests/range_variant_tests/data/range_variant_zk_config.json

@@ -4,10 +4,14 @@
 from unittest import mock
 
 from baseplate import ServerSpan
+from baseplate.lib.events import DebugLogger
 from baseplate.lib.file_watcher import FileWatcher
 from reddit_edgecontext import AuthenticationToken
 from reddit_edgecontext import User
 
+from reddit_decider import Decider
+from reddit_decider import DeciderContext
+from reddit_decider import init_decider_parser
 from reddit_experiments import Experiments
 
 ORIGINAL_ZK_CONFIG_FILE = "tests/range_variant_tests/data/original_zk_config.json"
@@ -29,6 +33,7 @@ def setUp(self):
         self.mock_span.trace_id = "123456"
         self.mock_authentication_token = mock.Mock(spec=AuthenticationToken)
         self.mock_authentication_token.user_roles = set()
+        self.event_logger = mock.Mock(spec=DebugLogger)
 
     def test_range_variant_bucketing_with_cfg_data(self):
         original_experiments = Experiments(
@@ -45,30 +50,58 @@ def test_range_variant_bucketing_with_cfg_data(self):
             cfg_data=self.range_variant_zk_config,
         )
 
+        filewatcher = FileWatcher(
+            path=RANGE_VARIANT_ZK_CONFIG_FILE, parser=init_decider_parser, timeout=2, backoff=2
+        )
+        extracted_fields = {"app_name": "", "build_number": 0}
+
         # results = {}
         for experiment_name in self.original_zk_config.keys():
             for i in range(NUMBER_OF_TEST_USERS):
                 uuid = "t2_" + str(i)
+
+                # experiments sdk
                 self.mock_authentication_token.subject = uuid
                 user = User(
                     authentication_token=self.mock_authentication_token,
                     loid=uuid,
                     cookie_created_ms=10000,
                 )
+
                 og_variant = original_experiments.variant(
-                    experiment_name, user=user, app_name="", build_number=0
-                )
-                rv_variant = rv_experiments.variant(
-                    experiment_name, user=user, app_name="", build_number=0
+                    experiment_name, user=user, **extracted_fields
                 )
+                rv_variant = rv_experiments.variant(experiment_name, user=user, **extracted_fields)
 
+                # compare experiments sdk in original data format to range-variants format
                 if og_variant != rv_variant:
                     print(f"\n\nexperiment: {experiment_name}")
                     print(f"uuid: {uuid}")
                     print(f"original variant: {og_variant}")
                     print(f"rv variant: {rv_variant}")
                 self.assertEqual(og_variant, rv_variant)
 
+                # decider sdk
+                decider_context = DeciderContext(user_id=uuid, extracted_fields=extracted_fields)
+
+                decider = Decider(
+                    decider_context=decider_context,
+                    config_watcher=filewatcher,
+                    server_span=self.mock_span,
+                    context_name="test",
+                    event_logger=self.event_logger,
+                )
+
+                decider_variant = decider.get_variant(experiment_name=experiment_name)
+
+                # compare decider sdk to original experiments sdk in range-variant format
+                if decider_variant != rv_variant:
+                    print(f"\n\nexperiment: {experiment_name}")
+                    print(f"uuid: {uuid}")
+                    print(f"rv variant: {rv_variant}")
+                    print(f"decider variant: {decider_variant}")
+                self.assertEqual(decider_variant, rv_variant)
+
                 # construct experiment/uuid to variant mapping
                 # used to compare results across baseplate languages
                 # results[experiment_name + ':' + uuid] = og_variant