Merge pull request #64 from reddit/denisse--add-loid-created-ms

Author: dm464

reddit_decider/__init__.py

@@ -64,6 +64,7 @@ def __init__(
         oauth_client_id: Optional[str] = None,
         origin_service: Optional[str] = None,
         cookie_created_timestamp: Optional[float] = None,
+        loid_created_timestamp: Optional[float] = None,
         extracted_fields: Optional[dict] = None,
     ):
         self._user_id = user_id
@@ -75,6 +76,7 @@ def __init__(
         self._oauth_client_id = oauth_client_id
         self._origin_service = origin_service
         self._cookie_created_timestamp = cookie_created_timestamp
+        self._loid_created_timestamp = loid_created_timestamp
         self._extracted_fields = extracted_fields
 
     def to_dict(self) -> Dict:
@@ -90,6 +92,7 @@ def to_dict(self) -> Dict:
             "oauth_client_id": self._oauth_client_id,
             "origin_service": self._origin_service,
             "cookie_created_timestamp": self._cookie_created_timestamp,
+            "loid_created_timestamp": self._loid_created_timestamp,
             "other_fields": ef,
             **ef,
         }
@@ -1053,6 +1056,17 @@ def make_object_for_context(self, name: str, span: Span) -> Decider:
                 f"Error while accessing `user.event_fields()` in `make_object_for_context()`. details: {exc}"
             )
 
+        loid_created_timestamp = None
+        try:
+            if isinstance(ec.authentication_token, ValidatedAuthenticationToken):
+                loid_cms = ec.authentication_token.loid_created_ms
+                if loid_cms:
+                    loid_created_timestamp = loid_cms
+        except Exception as exc:
+            logger.info(
+                f"Unable to access `ec.authentication_token.loid_created_ms` in `make_object_for_context()`. details: {exc}"
+            )
+
         oauth_client_id = None
         try:
             if isinstance(ec.authentication_token, ValidatedAuthenticationToken):
@@ -1115,6 +1129,7 @@ def make_object_for_context(self, name: str, span: Span) -> Decider:
                 device_id=device_id,
                 oauth_client_id=oauth_client_id,
                 cookie_created_timestamp=cookie_created_timestamp,
+                loid_created_timestamp=loid_created_timestamp,
                 extracted_fields=parsed_extracted_fields,
             )
         except Exception as exc:

tests/decider_tests.py

@@ -27,6 +27,7 @@
 COUNTRY_CODE = "US"
 DEVICE_ID = "abc"
 COOKIE_CREATED_TIMESTAMP = 1234
+LOID_CREATED_TIMESTAMP = 123456
 LOCALE_CODE = "us_en"
 ORIGIN_SERVICE = "origin"
 APP_NAME = "ios"
@@ -115,6 +116,9 @@ def setUp(self):
             spec=ValidatedAuthenticationToken
         )
         self.mock_span.context.edge_context.authentication_token.oauth_client_id = AUTH_CLIENT_ID
+        self.mock_span.context.edge_context.authentication_token.loid_created_ms = (
+            LOID_CREATED_TIMESTAMP
+        )
         self.mock_span.context.edge_context.geolocation.country_code = COUNTRY_CODE
         self.mock_span.context.edge_context.locale.locale_code = LOCALE_CODE
         self.mock_span.context.edge_context.origin_service.name = ORIGIN_SERVICE
@@ -154,6 +158,7 @@ def test_make_object_for_context_and_decider_context(self):
             decider_ctx_dict["cookie_created_timestamp"],
             self.mock_span.context.edge_context.user.event_fields().get("cookie_created_timestamp"),
         )
+        self.assertEqual(decider_ctx_dict["loid_created_timestamp"], LOID_CREATED_TIMESTAMP)
         self.assertEqual(decider_ctx_dict["app_name"], APP_NAME)
         self.assertEqual(decider_ctx_dict["other_fields"]["app_name"], APP_NAME)
         self.assertEqual(decider_ctx_dict["app_version"], APP_VERSION)
@@ -375,6 +380,7 @@ def setUp(self):
             device_id=DEVICE_ID,
             oauth_client_id=AUTH_CLIENT_ID,
             cookie_created_timestamp=COOKIE_CREATED_TIMESTAMP,
+            loid_created_timestamp=LOID_CREATED_TIMESTAMP,
             extracted_fields=decider_field_extractor(_request=None),
         )
 
@@ -1290,6 +1296,7 @@ def setUp(self):
             device_id=DEVICE_ID,
             oauth_client_id=AUTH_CLIENT_ID,
             cookie_created_timestamp=COOKIE_CREATED_TIMESTAMP,
+            loid_created_timestamp=LOID_CREATED_TIMESTAMP,
         )
 
     def setup_decider(self, file_name, decider_context):