Upgrade Argo CD to v3 in GitOps operator (#918)

* Upgrade Argo CD to v3 in GitOps operator

Signed-off-by: nmirasch <neus.miras@gmail.com>

* Update CRDs

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Update golang to 1.24 in CI

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Try brew image

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Use mirrored image

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Add root user to dockerfiles

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Use different image'

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Revert "Add root user to dockerfiles"

This reverts commit 34ac4b3.

* Revert ci-operator changes

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Use SkipNameValidation to avoid controller name validation

With controller-runtime v0.19.0, unique controller name validation is
enforced. The operator fails to start due to this as we don't have unique
names. Use SkipNameValidation to ingnore the uniquness check and prevent panic.

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Try rhel9 image

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Update operator to latest commit

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Try new golang image

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Update ci operator

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Fix rollouts upgrade hack go.sum

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* add ginkgo test changes

Signed-off-by: Varsha B <vab@redhat.com>

* Fix vendoring

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Update base image

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* fix old e2e tests

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Update Argo CD to v3.0.11

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

---------

Signed-off-by: nmirasch <neus.miras@gmail.com>
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Signed-off-by: Varsha B <vab@redhat.com>
Co-authored-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Co-authored-by: Varsha B <vab@redhat.com>

Author: 3 people

.ci-operator.yaml

@@ -1,4 +1,4 @@
 build_root_image:
-  name: release
-  namespace: openshift
-  tag: golang-1.22
+  name: builder
+  namespace: ocp
+  tag: rhel-9-golang-1.24-openshift-4.20

Dockerfile

@@ -1,5 +1,5 @@
 # Build the manager binary
-FROM golang:1.22 as builder
+FROM golang:1.24 as builder
 
 WORKDIR /workspace
 # Copy the Go Modules manifests

Makefile

@@ -116,8 +116,8 @@ test-all: manifests generate fmt vet ## Run all tests.
 
 .PHONY: test-e2e
 test-e2e: manifests generate fmt vet ## Run e2e tests.
-	go test -p 1 -timeout 1h ./test/e2e -coverprofile cover.out -ginkgo.v
-	go test -p 1 -timeout 1h ./test/nondefaulte2e -coverprofile cover.out -ginkgo.v
+	REDIS_CONFIG_PATH="build/redis" go test -p 1 -timeout 1h ./test/e2e -coverprofile cover.out -ginkgo.v
+	REDIS_CONFIG_PATH="build/redis" go test -p 1 -timeout 1h ./test/nondefaulte2e -coverprofile cover.out -ginkgo.v
 
 .PHONY: test-metrics
 test-metrics:
@@ -152,7 +152,7 @@ test-gitopsservice-nondefault:
 
 .PHONY: test
 test: manifests generate fmt vet ## Run unit tests.
-	go test `go list ./... | grep -v test` -coverprofile cover.out
+	REDIS_CONFIG_PATH="build/redis" go test `go list ./... | grep -v test` -coverprofile cover.out
 
 
 .PHONY: e2e-tests-ginkgo
@@ -267,7 +267,7 @@ undeploy: ## Undeploy controller from the K8s cluster specified in ~/.kube/confi
 CONTROLLER_GEN = $(shell pwd)/bin/controller-gen
 .PHONY: controller-gen
 controller-gen: ## Download controller-gen locally if necessary.
-	$(call go-get-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen@v0.14.0)
+	$(call go-get-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen@v0.18.0)
 
 KUSTOMIZE = $(shell pwd)/bin/kustomize
 .PHONY: kustomize

bundle/manifests/argoproj.io_applications.yaml

@@ -279,6 +279,10 @@ spec:
                   description: SyncWindow contains the kind, time, duration and attributes
                     that are used to assign the syncWindows to apps
                   properties:
+                    andOperator:
+                      description: UseAndOperator use AND operator for matching applications,
+                        namespaces and clusters instead of the default OR operator
+                      type: boolean
                     applications:
                       description: Applications contains a list of applications that
                         the window will apply to

bundle/manifests/argoproj.io_applicationsets.yaml

@@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.14.0
+    controller-gen.kubebuilder.io/version: v0.18.0
   creationTimestamp: null
   name: notificationsconfigurations.argoproj.io
 spec: