Consider to respect "telemetry.telemetryLevel"

[isidorn]

Hi VS Code PM here 👋

Consider to respect telemetry.telemetryLevel setting instead of introducing a new setting.
This way if the user disabled telemetry in once place it will be disabled in all extensions.

[fbricon]

I understand the feeling but unfortunately it's not really an option here.

• Your own documentation https://code.visualstudio.com/docs/getstarted/telemetry#_extensions-and-telemetry states:

These extensions may be collecting their own usage data and are not controlled by the telemetry.telemetryLevel setting

• the telemetry.telemetryLevel documentation explicitly mentions it applies to "core and first party extension telemetry"
• Red Hat and Microsoft each have their own privacy statements, the telemetry.telemetryLevel documentation explicitly links to the Microsoft one.

cc @mohitsuman

PS: the vscode-commons extension is being phased out, no other Red Hat extension should install it as a transitive dependency. If you find one, consider it a bug. All Red Hat extensions performing telemetry collection should now depend on a node library instead: https://github.com/redhat-developer/vscode-redhat-telemetry.

[isidorn]

Thanks for shedding more light here. If all the redhat extensions depend on your one module and if that one properly asks the user then I think we are good here.

Those docs are out of date and I plan to update them. Thanks for bringing them up.

Consider to close this as designed. Thanks