Interpret any non empty non success workflow conclusion as FAIL

Make logging_wrapper skip itself as a caller

Author: Peter-Sh

src/redis_release/bht/behaviours.py

@@ -799,6 +799,11 @@ def update(self) -> Status:
             ):
                 self.logger.info(f"Workflow completed with success status")
             return Status.SUCCESS
+        elif self.workflow.conclusion == WorkflowConclusion.FAILURE:
+            if self.log_once(
+                "workflow_unsuccessful", self.workflow.ephemeral.log_once_flags
+            ):
+                self.logger.error(f"Workflow completed with failure status")
         return Status.FAILURE
 
 

src/redis_release/bht/logging_wrapper.py

@@ -35,33 +35,17 @@ def __init__(self, logger: logging.Logger) -> None:
         self._logger = logger
 
     def debug(self, msg: str) -> None:
-        """Log a message with severity 'DEBUG'.
-
-        Args:
-            msg: The message to log
-        """
-        self._logger.debug(msg)
+        """Log a message with severity 'DEBUG'."""
+        self._logger.debug(msg, stacklevel=2)
 
     def info(self, msg: str) -> None:
-        """Log a message with severity 'INFO'.
-
-        Args:
-            msg: The message to log
-        """
-        self._logger.info(msg)
+        """Log a message with severity 'INFO'."""
+        self._logger.info(msg, stacklevel=2)
 
     def warning(self, msg: str) -> None:
-        """Log a message with severity 'WARNING'.
-
-        Args:
-            msg: The message to log
-        """
-        self._logger.warning(msg)
+        """Log a message with severity 'WARNING'."""
+        self._logger.warning(msg, stacklevel=2)
 
     def error(self, msg: str) -> None:
-        """Log a message with severity 'ERROR'.
-
-        Args:
-            msg: The message to log
-        """
-        self._logger.error(msg)
+        """Log a message with severity 'ERROR'."""
+        self._logger.error(msg, stacklevel=2)

src/redis_release/github_client_async.py

@@ -334,7 +334,7 @@ async def get_workflow_run(self, repo: str, run_id: int) -> WorkflowRun:
             conclusion = None
             if github_conclusion == "success":
                 conclusion = WorkflowConclusion.SUCCESS
-            elif github_conclusion == "failure":
+            elif github_conclusion is not None:
                 conclusion = WorkflowConclusion.FAILURE
 
             workflow_name = data.get("name", "unknown")