Align tests with RE (#447)

uglide · mgravell · web-flow · commit 1ca7020048ea · 2025-12-08T11:24:57.000Z
* Assert on index size before running queries in tests * Remove assertions on config options unsupported by RE * Fix formatting * Fix index size assertion * Add 8.4 to CI matrix integration.yml (#450) * Add 8.4 to CI matrix integration.yml * Update integration.yml * Update integration.yml * Update integration.yml * Assert on index size before running queries in tests * Remove assertions on config options unsupported by RE * Fix formatting * Fix index size assertion * Debug * Clean debugging * Skip search tests with cluster if Redis < 8.4 * Fix formatting * Clean up test matrix - 8.0 is for security fixes now, so the "current" version should be switched to 8.2 - 8.4 has stable release now * dotnet format * Update linter.yaml * more fixin' * Do not skip OSS Cluster tests on RE --------- Co-authored-by: Marc Gravell <marc.gravell@gmail.com>
diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml
@@ -17,7 +17,7 @@ concurrency:
 
 env:
   CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
-  CURRENT_REDIS_VERSION: '8.0.2'
+  CURRENT_REDIS_VERSION: '8.2.3'
 
 jobs:
     redis_version:
@@ -37,7 +37,7 @@ jobs:
         max-parallel: 15
         fail-fast: false
         matrix:
-          redis-version: [ '8.4-GA-pre.3', '8.2.1', '${{ needs.redis_version.outputs.CURRENT }}', '7.4.1', '7.2.6', '6.2.16']
+          redis-version: [ '8.4.0', '${{ needs.redis_version.outputs.CURRENT }}', '7.4.1', '7.2.6', '6.2.16']
           dotnet-version: ['8.0', '9.0']
       env:
         ACTIONS_ALLOW_UNSECURE_COMMANDS: true
diff --git a/.github/workflows/linter.yaml b/.github/workflows/linter.yaml
@@ -20,6 +20,10 @@ jobs:
         run: |
           dotnet format
 
+      - name: status
+        run: |
+          git status
+
       - name: Check for modified files
         run: |
           if (git status | Select-String -Pattern 'modified') {
diff --git a/src/NRedisStack/CoreCommands/Enums/SetInfoAttr.cs b/src/NRedisStack/CoreCommands/Enums/SetInfoAttr.cs
@@ -1,4 +1,5 @@
 namespace NRedisStack.Core;
+
 public enum SetInfoAttr
 {
     /// <summary>
diff --git a/src/NRedisStack/Search/AggregationRequest.cs b/src/NRedisStack/Search/AggregationRequest.cs
@@ -2,6 +2,7 @@
 using NRedisStack.Search.Literals;
 
 namespace NRedisStack.Search;
+
 public class AggregationRequest : IDialectAwareParam
 {
     private readonly List<object> args = []; // Check if Readonly
diff --git a/tests/Doc/Bf_tutorial.cs b/tests/Doc/Bf_tutorial.cs
@@ -9,6 +9,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/Bitmap_tutorial.cs b/tests/Doc/Bitmap_tutorial.cs
@@ -8,6 +8,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/CmdsGenericExample.cs b/tests/Doc/CmdsGenericExample.cs
@@ -8,6 +8,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/CmdsHashExample.cs b/tests/Doc/CmdsHashExample.cs
@@ -6,6 +6,7 @@
 using NRedisStack.Tests;
 
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/CmdsListExample.cs b/tests/Doc/CmdsListExample.cs
@@ -8,6 +8,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/CmdsSortedSetExamples.cs b/tests/Doc/CmdsSortedSetExamples.cs
@@ -8,6 +8,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/CmdsStringExample.cs b/tests/Doc/CmdsStringExample.cs
@@ -8,6 +8,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/Cms_tutorial.cs b/tests/Doc/Cms_tutorial.cs
@@ -10,6 +10,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/Cuckoo_tutorial.cs b/tests/Doc/Cuckoo_tutorial.cs
@@ -9,6 +9,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/Geo_tutorial.cs b/tests/Doc/Geo_tutorial.cs
@@ -8,6 +8,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/HashExample.cs b/tests/Doc/HashExample.cs
@@ -6,6 +6,7 @@
 
 //REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 //REMOVE_END
 public class HashExample
diff --git a/tests/Doc/Hll_tutorial.cs b/tests/Doc/Hll_tutorial.cs
@@ -8,6 +8,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/HomeJsonExample.cs b/tests/Doc/HomeJsonExample.cs
@@ -12,6 +12,7 @@
 using NRedisStack.Tests;
 
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/Json_tutorial.cs b/tests/Doc/Json_tutorial.cs
@@ -10,6 +10,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/ListTutorial.cs b/tests/Doc/ListTutorial.cs
@@ -9,6 +9,7 @@
 
 //REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 //REMOVE_END
 public class ListExample
diff --git a/tests/Doc/PipeTransExample.cs b/tests/Doc/PipeTransExample.cs
@@ -5,6 +5,7 @@
 using NRedisStack.Tests;
 
 namespace Doc;
+
 [Collection("DocsTests")]
 //REMOVE_END
 public class PipeTransExample
diff --git a/tests/Doc/QueryAggExample.cs b/tests/Doc/QueryAggExample.cs
@@ -12,6 +12,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/QueryEmExample.cs b/tests/Doc/QueryEmExample.cs
@@ -11,6 +11,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/QueryFtExample.cs b/tests/Doc/QueryFtExample.cs
@@ -11,6 +11,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/QueryRangeExample.cs b/tests/Doc/QueryRangeExample.cs
@@ -11,6 +11,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/SearchQuickstartExample.cs b/tests/Doc/SearchQuickstartExample.cs
@@ -9,6 +9,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 public class SearchQuickstartExample
diff --git a/tests/Doc/SetGetExample.cs b/tests/Doc/SetGetExample.cs
@@ -6,6 +6,7 @@
 
 //REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 //REMOVE_END
 public class SetGetExample
diff --git a/tests/Doc/SetsTutorial.cs b/tests/Doc/SetsTutorial.cs
@@ -8,6 +8,7 @@
 
 //REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 //REMOVE_END
 
diff --git a/tests/Doc/SortedSetExample.cs b/tests/Doc/SortedSetExample.cs
@@ -7,6 +7,7 @@
 
 //REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 //REMOVE_END
 public class SortedSetExample
diff --git a/tests/Doc/StreamTutorial.cs b/tests/Doc/StreamTutorial.cs
@@ -8,6 +8,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/StringSnippets.cs b/tests/Doc/StringSnippets.cs
@@ -7,6 +7,7 @@
 using StackExchange.Redis;
 
 namespace Doc;
+
 [Collection("DocsTests")]
 //REMOVE_END
 public class StringSnippets
diff --git a/tests/Doc/Tdigest_tutorial.cs b/tests/Doc/Tdigest_tutorial.cs
@@ -9,6 +9,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/TimeSeriesTutorial.cs b/tests/Doc/TimeSeriesTutorial.cs
@@ -15,6 +15,7 @@
 using NRedisStack;
 
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/Doc/Topk_tutorial.cs b/tests/Doc/Topk_tutorial.cs
@@ -9,6 +9,7 @@
 
 // REMOVE_START
 namespace Doc;
+
 [Collection("DocsTests")]
 // REMOVE_END
 
diff --git a/tests/NRedisStack.Tests/CommunityEditionUpdatesTests.cs b/tests/NRedisStack.Tests/CommunityEditionUpdatesTests.cs
@@ -35,14 +35,10 @@ public void ConfigSearchSettings(string endpointId)
 
         Assert.Single(server.ConfigGet("search-max-prefix-expansions"));
 
-        Assert.Single(server.ConfigGet("search-max-doctablesize"));
-
         Assert.Single(server.ConfigGet("search-max-search-results"));
 
         Assert.Single(server.ConfigGet("search-max-aggregate-results"));
 
-        Assert.Single(server.ConfigGet("search-friso-ini"));
-
         Assert.Single(server.ConfigGet("search-default-dialect"));
     }
 
diff --git a/tests/NRedisStack.Tests/Search/SearchTests.cs b/tests/NRedisStack.Tests/Search/SearchTests.cs

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`namespace NRedisStack.Core;`
	`2`	`+`
`2`	`3`	`public enum SetInfoAttr`
`3`	`4`	`{`
`4`	`5`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`	`using NRedisStack.Search.Literals;`
`3`	`3`
`4`	`4`	`namespace NRedisStack.Search;`
	`5`	`+`
`5`	`6`	`public class AggregationRequest : IDialectAwareParam`
`6`	`7`	`{`
`7`	`8`	`private readonly List<object> args = []; // Check if Readonly`