-
Notifications
You must be signed in to change notification settings - Fork 383
DEV: Consolidate ESLint configs #4726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pawelangelow
wants to merge
14
commits into
main
Choose a base branch
from
bugfix/unify-eslint-configs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,615
−3,002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage - Integration Tests
|
Code Coverage - Frontend unit tests
Test suite run success4793 tests passing in 628 suites. Report generated by 🧪jest coverage report action from 77a3cb3 |
valkirilov
previously approved these changes
Jul 17, 2025
Code Coverage - Backend unit tests
Test suite run success2941 tests passing in 286 suites. Report generated by 🧪jest coverage report action from 77a3cb3 |
valkirilov
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
ESLint supports multiple configurations across different directories, allowing for specific rules per project or folder. While this can be useful in large, highly distinct codebases, it introduces some downsides:
What’s Changed
This PR consolidates all ESLint configurations into a single, unified setup:
Benefits
This streamlines our setup without sacrificing rule specificity where it’s still needed.
This PR focuses solely on unifying the ESLint config - as you’ll notice, many rules are currently
turned off
. The goal here is to avoid one massive PR full of unrelated code changes triggered by lint rule enforcement.How We'll Apply the Rules
Instead of enabling everything at once, we’ll gradually reintroduce rules in focused PRs. Each PR will target a specific rule (or a group of related rules) and include only the files affected by those changes. This keeps the review process manageable and minimizes disruption.
Example
Let’s say we want to re-enable the
'prefer-const'
rule for the API codebase.Start by verifying a clean lint state:
Run
yarn lint:api
(oryarn lint
if you prefer). Using the specific api command provides faster feedback.Remove the override for the rule:
Delete the line
'prefer-const': 'off'
from the ESLint config (that particular section).Run the linter again:
You should now see 'prefer-const' errors reported.
Fix the reported issues.
Re-run the linter:
Make sure no linting errors remain.
Done!
Note:
If you're fixing lint issues in
api/test
orui/src/packages
, keep in mind that these directories may inherit rules from their parent configs. To see accurate lint results for these folders, you might need to temporarily disable parent-level overrides.