RI-7782: don't show notifications when masters array is empty #5253
+33
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemHoruzhenko
requested review from
DimoHG,
KrumTy,
dantovska,
pawelangelow,
pd-redis and
valkirilov
as code owners
pd-redis
approved these changes
Nov 27, 2025
valkirilov
approved these changes
Nov 27, 2025
Contributor
Code Coverage - Frontend unit tests
Test suite run success5424 tests passing in 703 suites. Report generated by 🧪jest coverage report action from 8731d18 |
KrumTy
approved these changes
Nov 27, 2025
Comment on lines
+48
to
+49
| const countFailAdded = masters?.length | ||
| ? masters.length - countSuccessAdded |
Collaborator
Author
There was a problem hiding this comment.
based on code - yes. In reality successfully added databases should be always <= masters number. This particular fix just ensures that masters are presented.
ArtemHoruzhenko
deleted the
fe/bugfix/RI-7782-fix-sentinel-discovery-result-notifications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Because of redux we might have a situation when masters array is empty when successfully added master groups is > 0. For such cases I've enhanced checks to not show notifications at all
Testing
Added storybook scenario, it could be verified there
Note
Hide MessageBar and compute failure count safely when
mastersis empty; add Storybook case to verify no notification is shown.SentinelDatabasesResult.tsx)countFailAddedwhenmastersis empty.MessageBaronly whenmasters.length > 0.NoNotificationWhenMastersAreNotProvidedscenario to validate no notification with emptymasters.Written by Cursor Bugbot for commit 8731d18. This will update automatically on new commits. Configure here.