[Bug] Flagging arbitrary entity as NPC no longer works.

[Endermanbugzjfc]

Description

Passing an $entity argument is no longer possible when calling NpcDialogue->sendTo().
I have tried myriad entity types below and all did not work:

• Player
• Custom entity created with Customies
• Zombie

Steps to reproduce

• Spawn the entity to player with code.
• Based on this code: https://github.com/refteams/libNpcDialogue/tree/e19b6328ad181372b3402357bc400562fe519f7a#api
• Add an $entity argument after sendTo($player,

Expectation

The dialogue opens with the given entity present.

Reality

The dialogue never opened.

Environment

Minecraft: 1.20.15 (Protocol 594)
PocketMine-MP: 5.4.3
libNpcDialogue: 1.0.0

[alvin0319]

My god, the goddamn Mojang broke this again...

[Endermanbugzjfc]

oh wtf it works today

[Endermanbugzjfc]

Still not sure about other entities...

[Endermanbugzjfc]

Initial debugging seems to suggest that this was caused by a race condition that the open-dialogue packet is sent before its entity's flags (network metadata) are synced to the client.

[Endermanbugzjfc]

Maybe call $entity->sendData() before opening the dialogue? Or schedule a delayed task.

[alvin0319]

libNpcDialogue/src/ref/libNpcDialogue/NpcDialogue.php

Lines 120 to 123 in e19b632

	if($entity instanceof Human){
	// This is a workaround for Human NPC
	$propertyManager->setString(EntityMetadataProperties::NPC_SKIN_INDEX, Utils::assumeNotFalse(json_encode($skinIndex)));
	}

Perhaps add sendData() here so that data could be synchronized before sending the dialogue packet.

[Endermanbugzjfc]

Uhh, it might be me forgot to put:

		if(!libNpcDialogue::isRegistered()){
			libNpcDialogue::register($this);
		}

I just read the README, not the example plugin. Maybe you should include that to the README as well?

Or is this not relevant?

[alvin0319]

Oh, didn't notice them. But is that fix the error? The register part is only for event handlers. Sending dialogue should not have effect by handler thing.