Skip to content

Conversation

@sbillinge
Copy link
Contributor

  • fix: bug in author list that didn't dereference names
  • news

@sbillinge
Copy link
Contributor Author

@stevenhua0320 I fixed a couple of bugs. Please take a look and let me know if you have thoughts. Some of the tests weren't testing as many of the behaviors as we wanted testing.

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.86%. Comparing base (c1c5a62) to head (1e6998a).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1274      +/-   ##
==========================================
+ Coverage   79.64%   79.86%   +0.22%     
==========================================
  Files          17       17              
  Lines        1366     1381      +15     
==========================================
+ Hits         1088     1103      +15     
  Misses        278      278              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge sbillinge merged commit 5bfb1bf into regro:main Nov 20, 2025
7 checks passed
@sbillinge sbillinge deleted the rlb-authors branch November 20, 2025 13:13
@stevenhua0320
Copy link
Contributor

Yes, the test right now is noy yet so comprehensive. We might add more as we progress on.

@sbillinge
Copy link
Contributor Author

Because of choices made early it turned out that it is hard to add comprehensive tests but we try and cover as many cases as we can by designing the exemplar. So I added a case where it has to dereference an id for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants