Potential issue with drop frames and some timestrings?

[kmturley]

This is a great library! I'm testing it out and have found a couple of question marks.

Looks like it accepts drop frames on invalid timecodes, and also a couple of the timestrings are a bit off? Have marked them with comments below

I've also put the examples into a fiddle:
http://jsfiddle.net/kmturley/6pq24/

---

Expected results

00:10:00:00@29.97 non drop = 18000
00:10:00:00@29.97 drop = 17982
00:10:00:00@25 = 15000

Actual results

00:10:00:00 - 18000
00:10:00;00 - 17982
00:10:00:00 - 15000

---

Expected results

10:00:00:00@29.97 non drop = 1080000
10:00:00;00@29.97 drop = 1078920
10:00:00:00@25 = 900000

Actual results

10:00:00:00 - 1080000
10:00:00;00 - 1078920
10:00:00:00 - 900000

---

Expected results

00:02:00:00@29.97 non drop = 3600
00:02:00;00@29.97 drop = this is an invalid timecode
00:02:00:00@25 = 3000

Actual results

00:02:00:00 - 3600
00:02:00;00 - 3596 // potential issue?
00:02:00:00 - 3000

---

Expected results

00:01:59:29@29.97 non drop = 3599
00:01:59;29@29.97 drop = 3597
00:01:59:29@25 = this is an invalid timecode

Actual results

00:01:59:29 - 3599
00:02:00;01 - 3597 // potential issue?
00:02:00:04 - 3004 // potential issue?

---

Expected results

00:02:00:01@29.97 non drop = 3601
00:02:00;01@29.97 drop = this is an invalid timecode
00:02:00:01 @25 = 3001

Actual results

00:02:00:01 - 3601
00:02:00;01 - 3597 // potential issue?
00:02:00:01 - 3001

[reidransom]

Thanks for this! I'll definitely include those in my testing and add some exceptions for flagging bad input.