Update tests to use html-dom-parser and prune unused helpers

Fix broken requires in tests now that `lib/html-to-dom-server.js`
and `lib/html-to-dom-client.js` have been deleted (use
`html-dom-parser` instead).

Remove HTML to DOM tests since `html-dom-parser` has its own tests.

Remove `helpers.deepEqualCircular()` and its tests as it was
used to test HTML to DOM parsing (which is no longer handled by
this package, but `html-dom-parser`).

Author: remarkablemark

test/dom-to-react.js

@@ -5,7 +5,7 @@
  */
 var assert = require('assert');
 var React = require('react');
-var htmlToDOMServer = require('../lib/html-to-dom-server');
+var htmlToDOM = require('html-dom-parser');
 var domToReact = require('../lib/dom-to-react');
 var helpers = require('./helpers/');
 var data = require('./data');
@@ -17,7 +17,7 @@ describe('dom-to-react parser', function() {
 
     it('converts single DOM node to React', function() {
         var html = data.html.single;
-        var reactElement = domToReact(htmlToDOMServer(html));
+        var reactElement = domToReact(htmlToDOM(html));
         assert(React.isValidElement(reactElement));
         assert.deepEqual(
             reactElement,
@@ -27,7 +27,7 @@ describe('dom-to-react parser', function() {
 
     it('converts multiple DOM nodes to React', function() {
         var html = data.html.multiple;
-        var reactElements = domToReact(htmlToDOMServer(html));
+        var reactElements = domToReact(htmlToDOM(html));
         reactElements.forEach(function(reactElement) {
             assert(React.isValidElement(reactElement));
             assert(reactElement.key);
@@ -44,7 +44,7 @@ describe('dom-to-react parser', function() {
     // https://facebook.github.io/react/docs/forms.html#why-textarea-value
     it('converts <textarea> correctly', function() {
         var html = data.html.textarea;
-        var reactElement = domToReact(htmlToDOMServer(html));
+        var reactElement = domToReact(htmlToDOM(html));
         assert(React.isValidElement(reactElement));
         assert.deepEqual(
             reactElement,
@@ -56,7 +56,7 @@ describe('dom-to-react parser', function() {
 
     it('does not escape <script> content', function() {
         var html = data.html.script;
-        var reactElement = domToReact(htmlToDOMServer(html));
+        var reactElement = domToReact(htmlToDOM(html));
         assert(React.isValidElement(reactElement));
         assert.deepEqual(
             reactElement,
@@ -70,7 +70,7 @@ describe('dom-to-react parser', function() {
 
     it('does not escape <style> content', function() {
         var html = data.html.style;
-        var reactElement = domToReact(htmlToDOMServer(html));
+        var reactElement = domToReact(htmlToDOM(html));
         assert(React.isValidElement(reactElement));
         assert.deepEqual(
             reactElement,
@@ -84,21 +84,21 @@ describe('dom-to-react parser', function() {
 
     it('does not have `children` for void elements', function() {
         var html = data.html.img;
-        var reactElement = domToReact(htmlToDOMServer(html));
+        var reactElement = domToReact(htmlToDOM(html));
         assert(!reactElement.props.children);
     });
 
     it('does not throw an error for void elements', function() {
         var html = data.html.void;
-        var reactElements = domToReact(htmlToDOMServer(html));
+        var reactElements = domToReact(htmlToDOM(html));
         assert.doesNotThrow(function() {
             helpers.render(React.createElement('div', {}, reactElements));
         });
     });
 
     it('skips HTML comments', function() {
         var html = [data.html.single, data.html.comment, data.html.single].join('');
-        var reactElements = domToReact(htmlToDOMServer(html));
+        var reactElements = domToReact(htmlToDOM(html));
         reactElements.forEach(function(reactElement) {
             assert(React.isValidElement(reactElement));
             assert(reactElement.key);

test/helpers.js

@@ -3,8 +3,6 @@
 /**
  * Module dependencies.
  */
-var assert = require('assert');
-var util = require('util');
 var React = require('react');
 var ReactDOMServer = require('react-dom/server');
 
@@ -21,65 +19,9 @@ function render(reactElement) {
     return ReactDOMServer.renderToStaticMarkup(reactElement);
 }
 
-/**
- * Test for deep equality between objects that have circular references.
- *
- * @param {Object} actual   - The actual object.
- * @param {Object} expected - The expected object.
- */
-function deepEqualCircular(actual, expected) {
-    var IS_VISITED_KEY = '_isVisited';
-
-    var actualKeys = Object.keys(actual).sort();
-    var expectedKeys = Object.keys(expected).sort();
-
-    // remove extraneous properties (if applicable)
-    var isVisitedKeyIndex = actualKeys.indexOf(IS_VISITED_KEY);
-    if (isVisitedKeyIndex > -1) {
-        actualKeys.splice(isVisitedKeyIndex, 1);
-    }
-
-    // compare object keys (sanity check)
-    assert.deepStrictEqual(actualKeys, expectedKeys);
-
-    // compare actual against expected
-    expectedKeys.forEach(function(key) {
-        var actualValue = actual[key];
-        var expectedValue = expected[key];
-
-        if (actualValue !== null && typeof actualValue === 'object') {
-            // actual and expected are not the same type
-            if (expectedValue !== null && typeof expectedValue.constructor === 'object') {
-                throw new Error(
-                    'Actual value: ' + util.inspect(actualValue) +
-                    '\n\nExpected value: ' +
-                    util.inspect(expectedValue)
-                );
-            }
-
-            // no need to revisit an already visited object
-            // this is to mitigate exceeding maximum call stack with circular reference
-            if (actualValue[IS_VISITED_KEY]) {
-                return;
-
-            // otherwise, walk through it
-            } else {
-                // taint the object to denote that it's been visited
-                actualValue[IS_VISITED_KEY] = true;
-                return deepEqualCircular(actualValue, expectedValue);
-            }
-
-        // compare the values as is
-        } else {
-            assert.deepStrictEqual(actualValue, expectedValue);
-        }
-    });
-}
-
 /**
  * Export assert helpers.
  */
 module.exports = {
-    deepEqualCircular: deepEqualCircular,
     render: render
 };