Fix Counter input preventing number entry with step > 1 #5966
+42
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Counter component's onChange handler immediately validated and rounded input values. With
step > 1, typing "2000" in increments of 1000 would reset to 0 on each keystroke since Math.round(2/1000) * 1000 = 0.Changes
inputValuestate to track raw input during typingisFocusedstate to defer validation while user is actively typingonChangetoonBlurviavalidateAndSetCount()useEffectto syncinputValuewhencountchanges externally (increment/decrement buttons)Before/After
Before:
After:
Result
Users can now type arbitrary values. Validation occurs on blur, allowing intermediate values like "2", "20", "200" before reaching "2000".
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.