Skip to content

feat(media): add crossOrigin prop to @remotion/media Audio & Video components #5989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(media): add crossOrigin prop to @remotion/media Audio & Video components #5989

wants to merge 7 commits into from
+212 −9

Conversation

@hnbnh
Copy link

@hnbnh hnbnh commented Nov 26, 2025 •
edited
Loading

@vercel
Copy link
Contributor

vercel bot commented Nov 26, 2025

@hnbnh is attempting to deploy a commit to the Remotion Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Contributor

vercel bot commented Nov 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
remotion Ready Ready Preview Comment Nov 28, 2025 3:07pm

@hnbnh hnbnh changed the title feat(media): add crossOrigin prop to Audio feat(media): add crossOrigin prop to @remotion/media Audio & Video components Nov 26, 2025
JonnyBurger
JonnyBurger requested changes Nov 27, 2025
View reviewed changes
Copy link
Member

@JonnyBurger JonnyBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR!

With using the new media tags, the URL will always be fetch()-ed and played with a custom implementation.

There is no underlying <video> or <audio> tag. Therefore the documentation and implementation in its current state is wrong.

Assets must be CORS-enabled to make use of the new @remotion/media tags.
If they are not, they fall back to the HTML5 tags: https://www.remotion.dev/docs/media/fallback#when-a-fallback-is-attempted

The only way this PR can make sense if we add support for the crossOrigin prop in case of a fallback. This prop should then be added under https://www.remotion.dev/docs/media/video#fallbackoffthreadvideoprops and https://www.remotion.dev/docs/media/audio#fallbackhtml5audioprops .

@hnbnh hnbnh marked this pull request as draft November 27, 2025 15:59
@hnbnh hnbnh force-pushed the feat/cross-origin-media branch from ffd4838 to 7eaafd1 Compare November 28, 2025 14:57
@hnbnh hnbnh force-pushed the feat/cross-origin-media branch from 7eaafd1 to 8858207 Compare November 28, 2025 15:03
@hnbnh hnbnh marked this pull request as ready for review November 28, 2025 15:21
@hnbnh hnbnh requested a review from JonnyBurger November 28, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonnyBurger JonnyBurger Awaiting requested review from JonnyBurger

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support crossOrigin for @remotion/media <Audio> & <Video>

2 participants

@hnbnh @JonnyBurger