Forced X11 header inclusion on GNU/Linux is wrong

[vanfanel]

Hi there,

I was building a project that depends on plume (Goemon64Recomp), and I got an error:

/home/manuel/src/n64recomp/Goemon64Recomp/lib/rt64/src/contrib/plume/plume_render_interface_types.h:23:10: fatal error: 'X11/Xlib.h' file not found
   23 | #include "X11/Xlib.h"
      |          ^~~~~~~~~~~~

That comes from here:

plume/plume_render_interface_types.h

Line 22 in dea63d3

#elif defined(__linux__)

That assumes that Linux=X11, which is not correct on modern GNU/Linux, where X11 may or may NOT be present (all major distros use Wayland by default now, with X11 being supported in legacy mode via xwayland).

This wrong assumption that Linux=X11 is again made here:

plume/plume_vulkan.h

Line 22 in dea63d3

#define VK_USE_PLATFORM_XLIB_KHR

And here:

plume/plume_vulkan.cpp

Line 56 in dea63d3

VK_KHR_XLIB_SURFACE_EXTENSION_NAME,

And here:

plume/plume_vulkan.cpp

Line 2118 in dea63d3

surfaceCreateInfo.sType = VK_STRUCTURE_TYPE_XLIB_SURFACE_CREATE_INFO_KHR;

All in all, VK_USE_PLATFORM_WAYLAND_KHR should be the default nowadays instead of VK_USE_PLATFORM_XLIB_KHR: X11 is legacy by now, and in fact it's on way out on some of the most popular distros (see: https://discourse.gnome.org/t/gnome-50-alpha-released/33616).
But if X11 compatibility is to be kept, at least some cmake configuration option like -DUSE_LEGACY_X11=ON to use X11 instead of Wayland should be provided, I guess.

Thanks!

[DarioSamo]

It seems plume just didn't carry over this PR, as it was submitted before the RHI forked off to being plume.

https://github.com/rt64/rt64/pull/184/files#diff-c3f1ef6af052dbf57cd0b396009e47618de0926394405e3446b80be9c0f5d7a2

It sounds like all you'd have to do is just repeat it here (only the bits under rhi and vulkan).

[vanfanel]

@DarioSamo Done in #88

...But once that's merged, I need the Recomp guys to pass -DPLUME_SDL_VULKAN_ENABLED=ON, I guess?

[DarioSamo]

...But once that's merged, I need the Recomp guys to pass -DPLUME_SDL_VULKAN_ENABLED=ON, I guess?

We do already!

[vanfanel]

...But once that's merged, I need the Recomp guys to pass -DPLUME_SDL_VULKAN_ENABLED=ON, I guess?

We do already!

Ah, great! Hadn't looked into it. Then, as soon as my PR is merged, things will be smooth for Wayland-only setups :)