Skip to content

Adopt uv in devcontainer and actions #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adopt uv in devcontainer and actions #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the
// README at: https://github.com/devcontainers/templates/tree/main/src/python
{
"name": "Python 3",
"name": "Python w/ UV",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/python:1-3.12-bullseye",
"image": "ghcr.io/astral-sh/uv:python3.12-bookworm-slim",
// Use 'onCreateCommand' to run commands after the container is created inside the container:
"onCreateCommand": "pip install --user -r requirements.txt",
"onCreateCommand": "uv sync",
// Configure tool-specific properties.
"customizations": {
"vscode": {
Expand Down
9 changes: 2 additions & 7 deletions .github/workflows/rendercv.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: "3.12"
- name: Install RenderCV
run: |
pip install -r requirements.txt
Comment on lines -21 to -23
Copy link
Contributor Author

@donaldguy donaldguy Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my quick testing an explicit uv sync was not necessary — it was installed on demand at uv run time (I'm assuming differing from uvx in that it respects the lock file still),

though obviously it might be better for cache coherence?

(but if that level of optimization is a goal I'd suggest that y'all might just want to push a full fledged container into ghcr.io/rendercv/rendercv [ see also porting this whole repo to being a GitHub action] )

- uses: astral-sh/setup-uv@v7
- name: RenderCV
run: |
cd src
Expand All @@ -30,7 +25,7 @@ jobs:
exit 1
fi
cd ..
rendercv render src/$cv_file --pdf-path ${cv_file%.yaml}.pdf --markdown-path README.md --typst-path ${cv_file%.yaml}.typ
uv run rendercv render src/$cv_file --pdf-path ${cv_file%.yaml}.pdf --markdown-path README.md --typst-path ${cv_file%.yaml}.typ
- name: Upload rendercv_output as an artifact
uses: actions/upload-artifact@v4
with:
Expand Down
11 changes: 11 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
[project]
name = "resume"
version = "0.1.0"
description = "John Does's resume as rendered w/ RenderCV"
requires-python = ">=3.14"
Copy link
Contributor Author

@donaldguy donaldguy Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, should be:

Suggested change
requires-python = ">=3.14"
requires-python = ">=3.12"

to match the change-as-little-as-possible I went for in devcontainer.json (or conversely update that to pull a 3.14 tag; I'd also go alpine probably)

I believe also determines version in rendercv pipeline?

dependencies = [
"rendercv[full]>=2.3",
]

[tool.uv]
required-version = ">= 0.9.8"
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop

This file was deleted.

Loading