Skip to content

Commit c456ca2

Browse files
committed
fix: skip the provided number of emitted values
When subscribing to a signal in the form of a subscribe, we ignore the first value. * Adds skip to the toObservable. * Updates app config mock to use provideEnvironmentInitializer Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
1 parent 0b9cf95 commit c456ca2

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

src/app/app.config.mock.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { provideHttpClient } from '@angular/common/http';
2-
import { ApplicationConfig, inject, provideAppInitializer, provideBrowserGlobalErrorListeners, provideZonelessChangeDetection } from '@angular/core';
2+
import { ApplicationConfig, inject, provideBrowserGlobalErrorListeners, provideEnvironmentInitializer, provideZonelessChangeDetection } from '@angular/core';
33
import { provideAnimationsAsync } from '@angular/platform-browser/animations/async';
44
import { provideRouter, TitleStrategy } from '@angular/router';
55
import Lara from '@primeuix/themes/lara';
@@ -18,8 +18,8 @@ export const appConfig: ApplicationConfig = {
1818
provideRouter(routes),
1919
provideHttpClient(),
2020
provideAnimationsAsync(),
21-
provideAppInitializer(() => {
22-
return inject(AppStateStore).loadSettings();
21+
provideEnvironmentInitializer(() => {
22+
inject(AppStateStore).loadSettings();
2323
}),
2424
providePrimeNG({
2525
ripple: true,

src/app/features/books/store/open-library.store.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { toObservable } from "@angular/core/rxjs-interop";
33
import { patchState, signalStore, withHooks, withMethods, withState } from "@ngrx/signals";
44
import { rxMethod } from "@ngrx/signals/rxjs-interop";
55
import { PaginatorState } from "primeng/paginator";
6-
import { debounceTime, pipe, switchMap, tap } from "rxjs";
6+
import { debounceTime, pipe, skip, switchMap, tap } from "rxjs";
77
import { withPaginator } from "../../../shared/store/paginator-feature";
88
import { setFulfilled, setPending, withRequestStatus } from "../../../shared/store/request-status-feature";
99
import { OpenLibraryApiResult, OpenLibraryRecord } from "../model/open-library.model";
@@ -51,7 +51,8 @@ export const OpenLibraryStore = signalStore(
5151
})),
5252
withHooks((store) => ({
5353
onInit: () => {
54-
toObservable(store.pager).subscribe(() => store.search(store.filter()));
54+
// skip: Skip the provided number of emitted values.
55+
toObservable(store.pager).pipe(skip(1)).subscribe(() => store.search(store.filter()));
5556
}
5657
}))
5758
);

src/app/shared/appSate/app-state-api.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import { debounceTime, Observable, of } from "rxjs";
1+
import { Injectable } from "@angular/core";
2+
import { Observable, of } from "rxjs";
23
import { Settings } from "./model/settings.model";
34
import { userData } from "./model/user.data";
45
import { User } from "./model/user.model";
5-
import { Injectable } from "@angular/core";
66

77

88
@Injectable({ providedIn: 'root' })

0 commit comments

Comments
 (0)