Remove dependency on tmpfile

We can make our own pseudo-unique temp file by just bumping an id

Author: chenglou

package-lock.json

@@ -97,8 +97,6 @@
 		"typescript": "^3.9.4"
 	},
 	"dependencies": {
-		"@types/tmp": "^0.2.0",
-		"chokidar": "^3.4.2",
-		"tmp": "^0.2.1"
+		"chokidar": "^3.4.2"
 	}
-}
+}

package.json

@@ -3,7 +3,6 @@ import { RequestMessage } from "vscode-languageserver";
 import * as utils from "./utils";
 import * as path from "path";
 import { exec } from "child_process";
-import * as tmp from "tmp";
 import fs from "fs";
 
 let binaryPath = path.join(
@@ -62,8 +61,7 @@ export function runCompletionCommand(
   if (executable == null) {
     onResult(null);
   } else {
-    let tmpobj = tmp.fileSync();
-    let tmpname = tmpobj.name;
+    let tmpname = utils.createFileInTempDir();
     fs.writeFileSync(tmpname, code, { encoding: "utf-8" });
 
     let command =
@@ -78,7 +76,8 @@ export function runCompletionCommand(
       tmpname;
 
     exec(command, { cwd: executable.cwd }, function (_error, stdout, _stderr) {
-      tmpobj.removeCallback();
+      // async close is fine. We don't use this file name again
+      fs.unlink(tmpname, () => null);
       let result = JSON.parse(stdout);
       if (result && result[0]) {
         onResult(result);

server/src/RescriptEditorSupport.ts

@@ -4,8 +4,17 @@ import * as childProcess from "child_process";
 import * as p from "vscode-languageserver-protocol";
 import * as path from "path";
 import * as t from "vscode-languageserver-types";
-import * as tmp from "tmp";
 import fs from "fs";
+import * as os from "os";
+
+let tempFilePrefix = "rescript_format_file_" + process.pid + "_";
+let tempFileId = 0;
+
+export let createFileInTempDir = (extension = "") => {
+	let tempFileName = tempFilePrefix + tempFileId + extension;
+	tempFileId = tempFileId + 1;
+	return path.join(os.tmpdir(), tempFileName);
+};
 
 // TODO: races here?
 // TODO: this doesn't handle file:/// scheme
@@ -39,15 +48,15 @@ export let formatUsingValidBscPath = (
 	bscPath: p.DocumentUri,
 	isInterface: boolean
 ): execResult => {
-	// library cleans up after itself. No need to manually remove temp file
-	let tmpobj = tmp.fileSync();
 	let extension = isInterface ? c.resiExt : c.resExt;
-	let fileToFormat = tmpobj.name + extension;
-	fs.writeFileSync(fileToFormat, code, { encoding: "utf-8" });
+	let formatTempFileFullPath = createFileInTempDir(extension);
+	fs.writeFileSync(formatTempFileFullPath, code, {
+		encoding: "utf-8",
+	});
 	try {
 		let result = childProcess.execFileSync(
 			bscPath,
-			["-color", "never", "-format", fileToFormat],
+			["-color", "never", "-format", formatTempFileFullPath],
 			{ stdio: "pipe" }
 		);
 		return {
@@ -59,6 +68,9 @@ export let formatUsingValidBscPath = (
 			kind: "error",
 			error: e.message,
 		};
+	} finally {
+		// async close is fine. We don't use this file name again
+		fs.unlink(formatTempFileFullPath, () => null);
 	}
 };