Skip to content

Bracket IPv6 host names if not bracketed by servlet container. #959 #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bracket IPv6 host names if not bracketed by servlet container. #959 #960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion modules/org.restlet.ext.servlet/src/org/restlet/ext/servlet/internal/ServletCall.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,14 @@ public int getClientPort() {
*/
@Override
public String getHostDomain() {
return getRequest().getServerName();
String serverName = getRequest().getServerName();

// Check if the servlet container returned an unbracketed IPv6 address
if (serverName.indexOf(':') != -1 && serverName.indexOf('[') == -1) {
return '[' + serverName + ']';
} else {
return serverName;
}
}

/**
Expand Down