Skip to content

isValidForm always return true #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pblinux opened this issue Jun 23, 2017 · 2 comments
Open

isValidForm always return true #10

pblinux opened this issue Jun 23, 2017 · 2 comments
Labels
bug
Milestone
v1.0.3

Comments

@pblinux
Copy link

pblinux commented Jun 23, 2017

Hi! First thanks for this project, is very very usefull.

I have a question, why isValidFrom method from FormBuildHelper always return true?

Thanks.
@RationalRank
Copy link

Hi @adib2149 @pblinux ! I faced that issue too. Checked the source code and found that the issue is with the isValidForm() method in FormBuildHelper.java . The value is not null and logs 0 when i checked it's length. So it remains true all the time.

@riddhimanadib
Copy link
Owner

Thanks, will fix this issue in the next release v1.0.3.

@riddhimanadib riddhimanadib added this to the v1.0.3 milestone Jun 25, 2017
riddhimanadib pushed a commit that referenced this issue Jul 27, 2017
fix #10: checked if value is empty instead of null
b156f55
@Fuhrmann Fuhrmann mentioned this issue Apr 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.0.3
Development

No branches or pull requests
3 participants
@riddhimanadib @pblinux @RationalRank