From c8ae7f6876c3a0f394677c58105e1adcd0feaac4 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Thu, 13 Oct 2022 12:00:07 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- mrparse/mr_jpred.py | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/mrparse/mr_jpred.py b/mrparse/mr_jpred.py index c8d8ec6..ad86aa5 100644 --- a/mrparse/mr_jpred.py +++ b/mrparse/mr_jpred.py @@ -197,7 +197,29 @@ def unpack_results(self, download_tgz): with tarfile.open(download_tgz, 'r:*') as tf: if not tf.getmembers(): raise RuntimeError(f'Empty archive: {download_tgz}') - tf.extractall(path=job_directory) + + import os + + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tf, path=job_directory) logger.debug(f'Extracted jpred files to: {job_directory}') return job_directory