Skip to content

Commit bacefb9

Browse files
committed
Use Array#every insted of Array#foreach in allFormsClean
1 parent d5598eb commit bacefb9

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

src/unsavedChanges.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -139,14 +139,10 @@ angular.module('unsavedChanges', ['resettable'])
139139
// if any one is dirty function will return true
140140

141141
function allFormsClean() {
142-
areAllFormsClean = true;
143-
angular.forEach(allForms, function(item, idx) {
144-
unsavedWarningsConfig.log('Form : ' + item.$name + ' dirty : ' + item.$dirty);
145-
if (item.$dirty) {
146-
areAllFormsClean = false;
147-
}
142+
return allForms.every(function(form, idx) {
143+
unsavedWarningsConfig.log('Form : ' + form.$name + ' dirty : ' + form.$dirty);
144+
return form.$pristine;
148145
});
149-
return areAllFormsClean; // no dirty forms were found
150146
}
151147

152148
// adds form controller to registered forms array
@@ -194,6 +190,7 @@ angular.module('unsavedChanges', ['resettable'])
194190

195191
$window.onbeforeunload = _this.confirmExit;
196192

193+
197194
var eventsToWatchFor = unsavedWarningsConfig.routeEvent;
198195

199196
angular.forEach(eventsToWatchFor, function(aEvent) {

0 commit comments

Comments
 (0)