linker errors in tests on armv7l,ppc64le, riscv64: undefined reference to `xdig_init'

[andreasstieger]

I am seeing architecture dependent linker errors trying to produce test_xdigest. This is on openSUSE Tumbleweed, packaging build

On armv7hl:

[   17s] [100%] Linking C executable test_xdigest
[   17s] /usr/bin/cmake -E cmake_link_script CMakeFiles/test_xdigest.dir/link.txt --verbose=1
[   17s] /usr/lib/gcc/armv7hl-suse-linux-gnueabi/15/../../../../armv7hl-suse-linux-gnueabi/bin/ld: /tmp/ccP4n1r7.ltrans0.ltrans.o: in function `main':
[   17s] /home/abuild/rpmbuild/BUILD/xdigest-0.4.0-build/xdigest-0.4.0/tests/test_xdigest.c:36:(.text.startup+0x30): undefined reference to `xdig_init'
[   17s] collect2: error: ld returned 1 exit status

On ppc64le:

[   27s] [100%] Linking C executable test_xdigest
[   27s] /usr/bin/cmake -E cmake_link_script CMakeFiles/test_xdigest.dir/link.txt --verbose=1
[   27s] /usr/lib64/gcc/powerpc64le-suse-linux/15/../../../../powerpc64le-suse-linux/bin/ld: /tmp/ccs3YMG5.ltrans0.ltrans.o: in function `main':
[   27s] /home/abuild/rpmbuild/BUILD/xdigest-0.4.0-build/xdigest-0.4.0/tests/test_xdigest.c:36:(.text.startup+0x38): undefined reference to `xdig_init'
[   27s] collect2: error: ld returned 1 exit status

On riscv64:

[  172s] [100%] Linking C executable test_xdigest
[  172s] /usr/bin/cmake -E cmake_link_script CMakeFiles/test_xdigest.dir/link.txt --verbose=1
[  172s] /usr/lib64/gcc/riscv64-suse-linux/15/../../../../riscv64-suse-linux/bin/ld: /tmp/cc3iI13A.ltrans0.ltrans.o: in function `main':
[  172s] /home/abuild/rpmbuild/BUILD/xdigest-0.4.0-build/xdigest-0.4.0/tests/test_xdigest.c:36:(.text.startup+0x1a): undefined reference to `xdig_init'
[  172s] collect2: error: ld returned 1 exit status

This is in the tests only, so passing -DENABLE_TESTS:BOOF=OFF works around this.

[rinrab]

Those architectures are not yet supported. In fact, in this configuration xdig_init symbol won't be exported at all because it currently checks for ARM64 only

xdigest/xdigest/core/armcap.c

Line 29 in 382efe4

#if defined(__aarch64__) || defined(_M_ARM64)

[andreasstieger]

Just to confirm, this is intentional even for the non-assembler implementations?

[rinrab]

It's not really intentional.. I think adding a proper check for those platforms should fix the build errors. Also openssl does have assembly implementations for these architectures so it should be possible port it.

[rinrab]

This should have been fixed in 0.5.0.