[BUG] Halo: Reach debug build [2010-10-25] failing on overlapping split

[ieee802dot11ac]

Repository URL

https://github.com/ieee802dot11ac/reach

Game Name

Halo: Reach

Game Version

Postlaunch debug build 2010-10-25

Description

 INFO Initial analysis completed (found 64500 functions)
xex: orig/4D53085B/halo3_cache_play.xex
 WARN unhandled header ID EnabledForCallcap    
 WARN unhandled header ID TLSInfo    
 WARN unhandled header ID DefaultStackSize    
 WARN unhandled header ID SystemFlags    
 WARN unhandled header ID ExecutionID    
 WARN unhandled header ID LANKey    
 WARN unhandled header ID AlternateTitleIDs    
 INFO Extracting exe to orig/4D53085B/halo3_cache_play.exe
 INFO Rebuilding relocations and splitting
 INFO tracker:fn{name=?network_life_cycle_can_change_network_files@@YA_NXZ start=3:0x824401F8 end=3:0x824402E0}: Guessed jump table @ 3:0x82440270 with entry count 20 (from 3:0x8244026C)    
 INFO tracker:fn{name=?player_training_update_player@@YAXJ@Z start=3:0x828B76B8 end=3:0x828B8198}: Guessed jump table @ 3:0x828B7E28 with entry count 24 (from 3:0x828B7E24)    
 INFO tracker:fn{name=?player_training_update_player@@YAXJ@Z start=3:0x828B76B8 end=3:0x828B8198}: Guessed jump table @ 3:0x828B79A0 with entry count 18 (from 3:0x828B799C)    
 INFO tracker:fn{name=?cache_file_copy_do_action@@YA_NXZ start=3:0x829D9FC0 end=3:0x829DB410}: Guessed jump table @ 3:0x829DA128 with entry count 24 (from 3:0x829DA124)    
 INFO tracker:fn{name=?cache_file_direct_open_do_action@@YA_NXZ start=3:0x829DB410 end=3:0x829DC0CC}: Guessed jump table @ 3:0x829DB564 with entry count 16 (from 3:0x829DB560)    
Failed: Split 0:0x82000600..0:0x82000644 overlaps with previous split

No splits within splits.txt overlap in that region.

[ieee802dot11ac]

Further investigation has seemingly led to a problem with create_gap_splits in util/split.rs, where file_iter.peek() is failing to properly update the value of split_start. Per gdb:

Breakpoint 2.1, dtk::util::split::create_gap_splits (obj=0x7fffffffa028) at src/util/split.rs:363
363                 ensure!(
(gdb) p split_start
$13 = dtk::analysis::cfa::SectionAddress {section: 0, address: 2181039616}
(gdb) p current_address
$14 = dtk::analysis::cfa::SectionAddress {section: 0, address: 2181039616}
(gdb) c
Continuing.

Breakpoint 2.1, dtk::util::split::create_gap_splits (obj=0x7fffffffa028) at src/util/split.rs:363
363                 ensure!(
(gdb) p split_start
$15 = dtk::analysis::cfa::SectionAddress {section: 0, address: 2181039616}
(gdb) p current_address
$16 = dtk::analysis::cfa::SectionAddress {section: 0, address: 2181039684}

Continuing from here caused the ensure split_start >= current_address to fail, prematurely ending analysis.