Uninitialised value in sep/extract.cpp

[TallFurryMan]

stellarsolver/stellarsolver/sep/extract.cpp

Lines 632 to 635 in e0aa8d3

	else if (newmarker == 'F')
	{
	ps = psstack[--pstop];
	if ((cs == NONOBJECT) && (ps == COMPLETE))

There is a code path that uses psstack without initialising it after allocation. That initialisation should probably be done around line 317.

[knro]

Initialize it how? by memset to 0 for example?

[TallFurryMan]

This is implementation-dependent. The code uses an uninitialised value, so results are undefined.

That's not what we want, so I'm not sure I get your question. This said, I suspect this happens in edge cases where markers are not written in the right order in the file, so any initialisation value would work.