iio: adc: stm32: fix bad error check on max_channels

Fabrice Gasnier · jic23 · commit 4fb840c95f82 · 2017-09-24T14:07:28.000+01:00
Fix a bad error check when counting 'st,adc-channels' array elements. This is seen when all channels are in use simultaneously. Fixes: 64ad7f6 ("iio: adc: stm32: introduce compatible data cfg") Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
@@ -1656,7 +1656,7 @@ static int stm32_adc_chan_of_init(struct iio_dev *indio_dev)
 
 	num_channels = of_property_count_u32_elems(node, "st,adc-channels");
 	if (num_channels < 0 ||
-	    num_channels >= adc_info->max_channels) {
+	    num_channels > adc_info->max_channels) {
 		dev_err(&indio_dev->dev, "Bad st,adc-channels?\n");
 		return num_channels < 0 ? num_channels : -EINVAL;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1656,7 +1656,7 @@ static int stm32_adc_chan_of_init(struct iio_dev *indio_dev)`
`1656`	`1656`
`1657`	`1657`	`num_channels = of_property_count_u32_elems(node, "st,adc-channels");`
`1658`	`1658`	`if (num_channels < 0 \|\|`
`1659`		`- num_channels >= adc_info->max_channels) {`
	`1659`	`+ num_channels > adc_info->max_channels) {`
`1660`	`1660`	`dev_err(&indio_dev->dev, "Bad st,adc-channels?\n");`
`1661`	`1661`	`return num_channels < 0 ? num_channels : -EINVAL;`
`1662`	`1662`	`}`