feat: do not use pathlib.Path.resolve because it is slow and we don't need to resolve links

Author: d-biehl

packages/core/src/robotcode/core/uri.py

@@ -181,6 +181,6 @@ def __iter__(self) -> Iterator[str]:
 
     def normalized(self) -> Uri:
         if self.scheme == "file":
-            return Uri.from_path(self.to_path().resolve())
+            return Uri.from_path(self.to_path().absolute())
 
         return Uri(str(self))

packages/debugger/src/robotcode/debugger/listeners.py

@@ -142,9 +142,9 @@ def log_message(self, message: Dict[str, Any]) -> None:
             item_id = next(
                 (
                     (
-                        f"{Path(item.source).resolve() if item.source is not None else ''};{item.longname}"
+                        f"{Path(item.source).absolute() if item.source is not None else ''};{item.longname}"
                         if item.type == "SUITE"
-                        else f"{Path(item.source).resolve() if item.source is not None else ''};"
+                        else f"{Path(item.source).absolute() if item.source is not None else ''};"
                         f"{item.longname};{item.line}"
                     )
                     for item in Debugger.instance().full_stack_frames
@@ -189,9 +189,9 @@ def message(self, message: Dict[str, Any]) -> None:
             item_id = next(
                 (
                     (
-                        f"{Path(item.source).resolve() if item.source is not None else ''};{item.longname}"
+                        f"{Path(item.source).absolute() if item.source is not None else ''};{item.longname}"
                         if item.type == "SUITE"
-                        else f"{Path(item.source).resolve() if item.source is not None else ''};"
+                        else f"{Path(item.source).absolute() if item.source is not None else ''};"
                         f"{item.longname};{item.line}"
                     )
                     for item in Debugger.instance().full_stack_frames
@@ -264,15 +264,15 @@ def start_suite(self, data: running.TestSuite, result: result.TestSuite) -> None
 
         def enqueue(item: Union[running.TestSuite, running.TestCase]) -> Iterator[str]:
             if isinstance(item, running.TestSuite):
-                yield f"{Path(item.source).resolve() if item.source is not None else ''};{item.longname}"
+                yield f"{Path(item.source).absolute() if item.source is not None else ''};{item.longname}"
 
                 for s in item.suites:
                     yield from enqueue(s)
                 for s in item.tests:
                     yield from enqueue(s)
                 return
 
-            yield f"{Path(item.source).resolve() if item.source is not None else ''};{item.longname};{item.lineno}"
+            yield f"{Path(item.source).absolute() if item.source is not None else ''};{item.longname};{item.lineno}"
 
         if self._event_sended:
             return

packages/language_server/src/robotcode/language_server/robotframework/diagnostics/imports_manager.py

@@ -315,7 +315,7 @@ async def check_file_changed(self, changes: List[FileEvent]) -> Optional[FileCha
                 path = uri.to_path()
                 if (
                     self._document is not None
-                    and (path.resolve() == self._document.uri.to_path().resolve())
+                    and (path.absolute() == self._document.uri.to_path().absolute())
                     or self._document is None
                 ):
                     await self._invalidate()
@@ -426,7 +426,7 @@ async def check_file_changed(self, changes: List[FileEvent]) -> Optional[FileCha
                 if (
                     self._lib_doc.source
                     and path.exists()
-                    and path.resolve().samefile(Path(self._lib_doc.source).resolve())
+                    and path.absolute().samefile(Path(self._lib_doc.source).absolute())
                 ):
                     await self._invalidate()
 
@@ -857,14 +857,14 @@ async def get_library_meta(
                     return None, import_name
 
                 if result.origin is not None:
-                    result.mtimes = {result.origin: Path(result.origin).resolve().stat().st_mtime_ns}
+                    result.mtimes = {result.origin: Path(result.origin).absolute().stat().st_mtime_ns}
 
                 if result.submodule_search_locations:
                     if result.mtimes is None:
                         result.mtimes = {}
                     result.mtimes.update(
                         {
-                            str(f): f.resolve().stat().st_mtime_ns
+                            str(f): f.absolute().stat().st_mtime_ns
                             for f in itertools.chain(
                                 *(iter_files(loc, "**/*.py") for loc in result.submodule_search_locations)
                             )
@@ -925,14 +925,14 @@ async def get_variables_meta(
                     return None, import_name
 
                 if result.origin is not None:
-                    result.mtimes = {result.origin: Path(result.origin).resolve().stat().st_mtime_ns}
+                    result.mtimes = {result.origin: Path(result.origin).absolute().stat().st_mtime_ns}
 
                 if result.submodule_search_locations:
                     if result.mtimes is None:
                         result.mtimes = {}
                     result.mtimes.update(
                         {
-                            str(f): f.resolve().stat().st_mtime_ns
+                            str(f): f.absolute().stat().st_mtime_ns
                             for f in itertools.chain(
                                 *(iter_files(loc, "**/*.py") for loc in result.submodule_search_locations)
                             )
@@ -1307,7 +1307,7 @@ async def _get_entry_for_resource_import(
         async def _get_document() -> TextDocument:
             self._logger.debug(lambda: f"Load resource {name} from source {source}")
 
-            source_path = Path(source).resolve()
+            source_path = Path(source).absolute()
             extension = source_path.suffix
             if extension.lower() not in RESOURCE_EXTENSIONS:
                 raise ImportError(

packages/language_server/src/robotcode/language_server/robotframework/diagnostics/library_doc.py

@@ -2200,9 +2200,9 @@ def complete_library_import(
     if name is None or (is_file_like(name) and (name.endswith(("/", os.sep)))):
         name_path = Path(name if name else base_dir)
         if name_path.is_absolute():
-            path = name_path.resolve()
+            path = name_path.absolute()
         else:
-            path = Path(base_dir, name if name else base_dir).resolve()
+            path = Path(base_dir, name if name else base_dir).absolute()
 
         if path.exists() and path.is_dir():
             result += [
@@ -2263,9 +2263,9 @@ def complete_resource_import(
     if name is None or name.startswith((".", "/", os.sep)):
         name_path = Path(name if name else base_dir)
         if name_path.is_absolute():
-            path = name_path.resolve()
+            path = name_path.absolute()
         else:
-            path = Path(base_dir, name if name else base_dir).resolve()
+            path = Path(base_dir, name if name else base_dir).absolute()
 
         if path.exists() and (path.is_dir()):
             result += [
@@ -2359,9 +2359,9 @@ def complete_variables_import(
     if name is None or name.startswith((".", "/", os.sep)):
         name_path = Path(name if name else base_dir)
         if name_path.is_absolute():
-            path = name_path.resolve()
+            path = name_path.absolute()
         else:
-            path = Path(base_dir, name if name else base_dir).resolve()
+            path = Path(base_dir, name if name else base_dir).absolute()
 
         if path.exists() and (path.is_dir()):
             result += [

packages/robot/src/robotcode/robot/config/loader.py

@@ -128,9 +128,9 @@ def load_robot_config_from_path(*__paths: Union[Path, Tuple[Path, ConfigType]])
 
 def find_project_root(*sources: Union[str, Path]) -> Tuple[Optional[Path], DiscoverdBy]:
     if not sources:
-        sources = (str(Path.cwd().resolve()),)
+        sources = (str(Path.cwd().absolute()),)
 
-    path_srcs = [Path(Path.cwd(), src).resolve() for src in sources]
+    path_srcs = [Path(Path.cwd(), src).absolute() for src in sources]
 
     src_parents = [list(path.parents) + ([path] if path.is_dir() else []) for path in path_srcs]
 

packages/runner/src/robotcode/runner/cli/discover/discover.py

@@ -224,12 +224,13 @@ def get_rel_source(source: Optional[str]) -> Optional[str]:
 class Collector(SuiteVisitor):
     def __init__(self) -> None:
         super().__init__()
+        absolute_path = Path.cwd()
         self.all: TestItem = TestItem(
             type="workspace",
-            id=str(Path.cwd().resolve()),
-            name=Path.cwd().name,
-            longname=Path.cwd().name,
-            uri=str(Uri.from_path(Path.cwd())),
+            id=str(absolute_path),
+            name=absolute_path.name,
+            longname=absolute_path.name,
+            uri=str(Uri.from_path(absolute_path)),
             needs_parse_include=get_robot_version() >= (6, 1),
         )
         self._current = self.all
@@ -255,12 +256,13 @@ def visit_suite(self, suite: TestSuite) -> None:
         self._collected[-1][suite.name] = True
         self._collected.append(NormalizedDict(ignore="_"))
         try:
+            absolute_path = Path(suite.source).absolute() if suite.source else None
             item = TestItem(
                 type="suite",
-                id=f"{Path(suite.source).resolve() if suite.source is not None else ''};{suite.longname}",
+                id=f"{absolute_path or ''};{suite.longname}",
                 name=suite.name,
                 longname=suite.longname,
-                uri=str(Uri.from_path(Path(suite.source).resolve())) if suite.source else None,
+                uri=str(Uri.from_path(absolute_path)) if absolute_path else None,
                 source=str(suite.source),
                 rel_source=get_rel_source(suite.source),
                 range=Range(
@@ -307,12 +309,13 @@ def visit_test(self, test: TestCase) -> None:
         if self._current.children is None:
             self._current.children = []
         try:
+            absolute_path = Path(test.source).absolute() if test.source is not None else None
             item = TestItem(
                 type="test",
-                id=f"{Path(test.source).resolve() if test.source is not None else ''};{test.longname};{test.lineno}",
+                id=f"{absolute_path or ''};{test.longname};{test.lineno}",
                 name=test.name,
                 longname=test.longname,
-                uri=str(Uri.from_path(Path(test.source).resolve())) if test.source else None,
+                uri=str(Uri.from_path(absolute_path)) if absolute_path else None,
                 source=str(test.source),
                 rel_source=get_rel_source(test.source),
                 range=Range(
@@ -383,7 +386,7 @@ def add_diagnostic(
         line: Optional[int] = None,
         text: Optional[str] = None,
     ) -> None:
-        source_uri = str(Uri.from_path(Path(source_uri).resolve() if source_uri else Path.cwd()))
+        source_uri = str(Uri.from_path(Path(source_uri).absolute() if source_uri else Path.cwd()))
 
         if source_uri not in result:
             result[source_uri] = []

tests/robotcode/language_server/robotframework/parts/conftest.py

@@ -32,7 +32,7 @@
 
 @pytest_asyncio.fixture(scope="package", ids=generate_test_id)
 async def protocol(request: Any) -> AsyncIterator[RobotLanguageServerProtocol]:
-    root_path = Path(Path(__file__).resolve().parent, "data")
+    root_path = Path(Path(__file__).absolute().parent, "data")
     robotcode_cache_path = root_path / ".robotcode_cache"
 
     if robotcode_cache_path.exists():