[BUG]: Examples need porting for 2025 Revlib

[sciencewhiz]

Problem description

It looks like none of the robotpy-rev examples have been ported for 2025. For example, they use CANSparkMax instead of SparkMax. https://docs.revrobotics.com/brushless/revlib/revlib-overview/migrating-to-revlib-2025

https://www.chiefdelphi.com/t/coding-for-rev-robotics-swerve-drive-using-robotpy/482757/3

[virtuald]

Yeah, we probably should run tests on the examples in CI to catch things like this.

[virtuald]

Fixed in #74

[sciencewhiz]

can-arcade-drive, can-tank-drive, getting-started, and limit-switch were done in #74.

The following still need to be done:

• color_match
• maxswerve
• position-pid-control
• read_rgb_values
• read-encoder-values
• smart-motion
• velocity-pid-control

[rtestardi]

We could also use the maxswerve example, as we are trying to switch from java to python this year -- would anyone know if this exists somewhere? thanks!

[virtuald]

It's at https://github.com/robotpy/robotpy-rev/tree/main/examples/maxswerve but I don't know if it has been upgraded. Should be a good starting point either way.

[rtestardi]

Thanks, unfortunately that example has not been upgraded -- you can tell by the existence of "CANSparkMax" in subsystems/maxswervemodule.py and constants.py (which becomes just "SparkMax" after upgrade). We were just hoping for examples that had a high likelihood of working (i.e., had actually been tested) as we are new to python (the Java example from Rev "just works"). Anyway, we'll give it a try as we upgraded our Java code last year, using that as a template -- mostly the motor configuration model change (as opposed to the renames) are what took the most time to figure out... Anyway, thanks for the response. Rich

[rtestardi]

If it helps anyone else, I believe I have maxswerve example working with the new revlib here:

https://github.com/bIrobot/2026.git

Only constants.py and subsystems/maxswervemodule.py are changed from the original example.

I'll try and clean things up over the next few days before adding non-example functionality.

Curiously the physical robot works, but not the simulator -- I'll try to figure that out as well...

[virtuald]

It would probably be more helpful for others if you made a pull request to this repo with your edits once it works?

[rtestardi]

Sure, I will do that once I am happy with it -- but I'm hoping to get critical reviews from someone who actually knows this stuff (because I'm not that guy) -- I wouldn't want the pull-request blindly accepted based on my word! :-)

[virtuald]

Feel free to make a PR whenever you think it's good enough. It's a lot easier to review a pull request's diff than it is to review an entire repo.