Unreachable code

[killmenot]

ewd-document-store/lib/proto/setDocument.js

Line 57 in 55179cb

if (value === null) value = '';

This doesn't work because

var a = null;
typeof a === 'object' // true

above, we have this validation: https://github.com/robtweed/ewd-document-store/blob/master/lib/proto/setDocument.js#L49

[killmenot]

Another such place:

ewd-document-store/lib/proto/setDocument.js

Line 69 in 55179cb

if (value === null || typeof value === 'undefined') value = '';

[robtweed]

So the problem you're highlighting would occur if an array within the object we're saving to global storage contained a member that was null, right?

[killmenot]

I think highlighting lines are not correct because value cannot be null or undefined on these steps. Let me explain:

1. If we consider line 58. This line makes no sense because if value (a.k.a. obj[i][j]) is null, we went this way because type of for null is 'object'.

2. If we consider second scenario. Line 68 can be passed when obj[i] is undefined (typeof -> 'undefined') but will be skipped if obj[i] is null. This means that line 70 should be

if (typeof value === 'undefined') value = '';

Another option here to have line 68

if (obj[i] === null || typeof obj[i] !== 'object')

[robtweed]

Unfortunately I don't have any examples to hand, but those conditions were added specifically as a result of scenarios I encountered where they proved to be required. I'd rather leave them in now than remove them at the risk of breaking anything

[killmenot]

OK, try to provide examples