`aup` stuck in infite loop when updating archive packages

[moooeeeep]

When I install a package from an archive and update the archive link (e.g., to update the version), without specifying AUTOBUILD_ARCHIVE_AUTOUPDATE=1 and without clearing the cache, aup gets stuck in an infinite loop:

[...]
  update failed external/lemon
  update failed external/lemon
  update failed external/lemon
  update failed external/lemon
  update failed external/lemon
^C  interrupted external/lemon

Interrupted by user

I can reproduce it with this buildconf manifest:

package_sets:
 - github: rock-core/rock-package_set
layout:
 - external/lemon

It gets stuck, when I then (after installation) change the link to select another version of the package, e.g., like this

--- source.yml
+++ source.yml
@@ -302,7 +302,7 @@ version_control:
 
     - external/lemon:
       type: archive
-      url: http://lemon.cs.elte.hu/pub/sources/lemon-1.3.1.tar.gz
+      url: http://lemon.cs.elte.hu/pub/sources/lemon-1.2.4.tar.gz
       update_cached_file: false
       patches:
             - $AUTOPROJ_SOURCE_DIR/patches/lemon_cmake.patch

The exception is raised here. Not sure where exactly the infinite loop is going on.

This seems to also happen with update_cached_file: true

[moooeeeep]

It seems the exception is caught and ignored here.

Therefore the package is never removed from the queue and the loop doesn't stop.

[doudou]

Hi @moooeeeep. Thanks for the report.

It seems the exception is caught and ignored here.

Not that simple ;-) The error e is added to completion_queue and is then managed afterwards.