Skip to content

Commit fcac5b8

Browse files
author
Rocket Web
authored
Merge pull request #7 from rocketweb/ICP-10_incorrect_return_value
setting correct return value according to Symfony core code [#10]
2 parents 70759f2 + 430f147 commit fcac5b8

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

Console/Command/DumpCmsData.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ protected function configure()
6363
parent::configure();
6464
}
6565

66-
protected function execute(InputInterface $input, OutputInterface $output): void
66+
protected function execute(InputInterface $input, OutputInterface $output): int
6767
{
6868
$type = $input->getOption(self::INPUT_KEY_TYPE);
6969
$removeAll = (bool)$input->getOption(self::INPUT_KEY_REMOVE_ALL);
@@ -87,5 +87,7 @@ protected function execute(InputInterface $input, OutputInterface $output): void
8787
}
8888

8989
$this->dumpCmsDataService->execute($types, $identifiers, $removeAll);
90+
91+
return 0;
9092
}
9193
}

Console/Command/ImportCmsData.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ protected function configure()
6565
parent::configure();
6666
}
6767

68-
protected function execute(InputInterface $input, OutputInterface $output): void
68+
protected function execute(InputInterface $input, OutputInterface $output): int
6969
{
7070
$type = $input->getOption(self::INPUT_KEY_TYPE);
7171
$importAll = (bool)$input->getOption(self::INPUT_KEY_IMPORT_ALL);
@@ -89,5 +89,7 @@ protected function execute(InputInterface $input, OutputInterface $output): void
8989
}
9090

9191
$this->importCmsDataService->execute($types, $identifiers, $importAll);
92+
93+
return 0;
9294
}
9395
}

0 commit comments

Comments
 (0)