NL at EOF?

[krlmlr]

Most .sh files are missing a final newline. I have tried to work around with editorconfig, but this isn't supported with my editor: editorconfig/editorconfig-vscode#153.

Do you feel strongly about newlines at EOF? Would an .editorconfig that enables this setting only for this project help?

[roeme]

Nah, I don't feel strongly about them. My tools don't really care, and the odd diff highlighting a \r,\n or \r\n doesn't impede anything here. Feel free to PR adding newlines. As for editorconfig, I don't use it, I prefer Modelines.