Skip to content

Plugin reading from chunks instead of assets #16

@mmmoussa

Description

@mmmoussa

This plugin uses the emit event of the compiler. According to the webpack docs, at this stage "the Compiler begins with emitting the generated assets. Here plugins have the last chance to add assets to the c.assets array." At this point in the webpack process I don't think it is correct for WebpackRtlPlugin to be using and updating the compilation chunks for operations. It should instead be using the compilation assets.

In one of my use cases for this plugin, I am using AddAssetHtmlPlugin to add some additional css files. AddAssetHtmlPlugin is being executed before WebpackRtlPlugin and is only adding assets to compilation.assets and not compilations.chunks, resulting in WebpackRtlPlugin not building the rtl version of these assets.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions