From edfba890d54dcbfd89efb2c20699d038d9d18ffc Mon Sep 17 00:00:00 2001 From: Sergey Dikiy Date: Sun, 17 May 2020 22:57:38 +0300 Subject: [PATCH 1/2] feat wetaher: add weatherstack client --- clients/weather/weatherstack/__init__.py | 9 +++++++-- weather/views.py | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/clients/weather/weatherstack/__init__.py b/clients/weather/weatherstack/__init__.py index c8aa451..80dc5af 100644 --- a/clients/weather/weatherstack/__init__.py +++ b/clients/weather/weatherstack/__init__.py @@ -8,7 +8,12 @@ def get_weather(city): response = requests.get( 'http://api.weatherstack.com/current', params={ + 'access_key': access_key, + 'query': city, + 'units': 's', } ) - - return models.Weather(temperature=273.15) + temperature = response.json()['current']['temperature'] + print (response.json()) + print (type(response.text)) + return models.Weather(temperature=temperature) diff --git a/weather/views.py b/weather/views.py index 5c3d11d..ef72a0f 100644 --- a/weather/views.py +++ b/weather/views.py @@ -1,6 +1,6 @@ from django.http import HttpResponse -import clients.weather.open_weather_map as weather +import clients.weather.weatherstack as weather def index(request): From d36e18bddd8eb9bcfc99f9b51c66f2f62c5a15bf Mon Sep 17 00:00:00 2001 From: Sergey Dikiy Date: Sun, 17 May 2020 23:20:09 +0300 Subject: [PATCH 2/2] for pr review --- clients/weather/weatherstack/__init__.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/clients/weather/weatherstack/__init__.py b/clients/weather/weatherstack/__init__.py index 80dc5af..71b00fb 100644 --- a/clients/weather/weatherstack/__init__.py +++ b/clients/weather/weatherstack/__init__.py @@ -14,6 +14,5 @@ def get_weather(city): } ) temperature = response.json()['current']['temperature'] - print (response.json()) - print (type(response.text)) + return models.Weather(temperature=temperature)