Skip to content

Commit a2cb0a6

Browse files
committed
[cmake][win] Fix compilation errors on Windows
Fix the following compilation errors on Windows: ``` error C1128: number of sections exceeded object file format limit: compile with /bigobj ```
1 parent a3ba8ab commit a2cb0a6

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

tree/dataframe/test/CMakeLists.txt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@ ROOT_ADD_GTEST(dataframe_utils dataframe_utils.cxx LIBRARIES ROOTDataFrame)
2020
ROOT_ADD_GTEST(dataframe_report dataframe_report.cxx LIBRARIES ROOTDataFrame)
2121
ROOT_ADD_GTEST(dataframe_incomplete_entries dataframe_incomplete_entries.cxx LIBRARIES ROOTDataFrame)
2222

23-
2423
if(MSVC)
24+
set_source_files_properties(dataframe_cloning.cxx PROPERTIES COMPILE_FLAGS /bigobj)
25+
set_source_files_properties(dataframe_interface.cxx PROPERTIES COMPILE_FLAGS /bigobj)
2526
set_property(TARGET dataframe_cache APPEND_STRING PROPERTY LINK_FLAGS " -STACK:10000000")
2627
set_property(TARGET dataframe_interface APPEND_STRING PROPERTY LINK_FLAGS " -STACK:10000000")
2728
endif()
@@ -67,6 +68,9 @@ ROOT_ADD_GTEST(dataframe_merge_results dataframe_merge_results.cxx LIBRARIES ROO
6768
ROOT_ADD_GTEST(dataframe_samplecallback dataframe_samplecallback.cxx CounterHelper.h LIBRARIES ROOTDataFrame)
6869
ROOT_ADD_GTEST(dataframe_vary dataframe_vary.cxx LIBRARIES ROOTDataFrame)
6970
ROOT_ADD_GTEST(dataframe_compgraph dataframe_compgraph.cxx LIBRARIES ROOTDataFrame)
71+
if(MSVC)
72+
set_source_files_properties(dataframe_vary.cxx COMPILE_FLAGS /bigobj)
73+
endif()
7074

7175
#### TESTS FOR DIFFERENT DATASOURCES ####
7276
if(MSVC AND MSVC_VERSION GREATER_EQUAL 1925 AND MSVC_VERSION LESS 1929 OR CMAKE_CXX_STANDARD LESS 17)
@@ -89,9 +93,6 @@ configure_file(spec.json . COPYONLY)
8993
configure_file(pyspec.json . COPYONLY)
9094
configure_file(spec_ordering_samples_withFriends.json . COPYONLY)
9195
ROOT_ADD_GTEST(datasource_csv datasource_csv.cxx LIBRARIES ROOTDataFrame)
92-
if(MSVC AND CMAKE_SIZEOF_VOID_P EQUAL 8)
93-
set_source_files_properties(dataframe_vary.cxx COMPILE_FLAGS "-bigobj")
94-
endif()
9596

9697
#### TESTS REQUIRING EXTRA ROOT FEATURES ####
9798
if (imt)

0 commit comments

Comments
 (0)