Revert "Drop deprecation warnings"

This reverts commit d8e320a.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

Author: hidmic

launch/launch/utilities/signal_management.py

@@ -25,6 +25,7 @@
 from typing import Optional
 from typing import Tuple  # noqa: F401
 from typing import Union
+import warnings
 
 import osrf_pycommon.process_utils
 
@@ -261,6 +262,11 @@ def on_sigint(handler):
 
       Use AsyncSafeSignalManager instead
     """
+    warnings.warn(
+        'Global signal management APIs are deprecated. Do not use on_sigint(). '
+        'Use the AsyngSafeSignalManager instead.',
+        DeprecationWarning
+    )
     __global_signal_manager.handle(signal.SIGINT, handler)
 
 
@@ -279,6 +285,11 @@ def on_sigquit(handler):
 
       Use AsyncSafeSignalManager instead
     """
+    warnings.warn(
+        'Global signal management APIs are deprecated. Do not use on_sigquit(). '
+        'Use the AsyngSafeSignalManager instead.',
+        DeprecationWarning
+    )
     if platform.system() != 'Windows':
         __global_signal_manager.handle(signal.SIGQUIT, handler)
 
@@ -295,6 +306,11 @@ def on_sigterm(handler):
 
       Use AsyncSafeSignalManager instead
     """
+    warnings.warn(
+        'Global signal management APIs are deprecated. Do not use on_sigterm(). '
+        'Use the AsyngSafeSignalManager instead.',
+        DeprecationWarning
+    )
     __global_signal_manager.handle(signal.SIGTERM, handler)
 
 
@@ -324,4 +340,10 @@ def install_signal_handlers():
         if __global_signal_manager_activated:
             return
         __global_signal_manager_activated = True
+    warnings.warn(
+        'Global signal management APIs are deprecated. '
+        'Do not use install_signal_handlers(). '
+        'Use the AsyngSafeSignalManager instead.',
+        DeprecationWarning
+    )
     __global_signal_manager.__enter__()

launch/test/launch/utilities/test_signal_management.py

@@ -123,59 +123,63 @@ def test_async_safe_signal_manager():
 
 def test_install_signal_handlers():
     """Test the install_signal_handlers() function."""
-    install_signal_handlers()
-    install_signal_handlers()
-    install_signal_handlers()
+    with pytest.deprecated_call():
+        install_signal_handlers()
+        install_signal_handlers()
+        install_signal_handlers()
 
 
 def test_on_sigint():
     """Test the on_sigint() function."""
-    # None is acceptable
-    on_sigint(None)
+    with pytest.deprecated_call():
+        # None is acceptable
+        on_sigint(None)
 
-    def mock_sigint_handler():
-        pass
+        def mock_sigint_handler():
+            pass
 
-    on_sigint(mock_sigint_handler)
+        on_sigint(mock_sigint_handler)
 
-    # Non-callable is not
-    with pytest.raises(ValueError):
-        on_sigint('non-callable')
+        # Non-callable is not
+        with pytest.raises(ValueError):
+            on_sigint('non-callable')
 
-    # TODO(jacobperron): implement a functional test by using subprocess.Popen
+        # TODO(jacobperron): implement a functional test by using subprocess.Popen
 
 
 @pytest.mark.skipif(platform.system() == 'Windows',
                     reason='No SIGQUIT on Windows')
 def test_on_sigquit():
     """Test the on_sigquit() function."""
-    # None is acceptable
-    on_sigquit(None)
+    with pytest.deprecated_call():
+        # None is acceptable
+        on_sigquit(None)
 
-    def mock_sigquit_handler():
-        pass
+        def mock_sigquit_handler():
+            pass
 
-    on_sigquit(mock_sigquit_handler)
+        on_sigquit(mock_sigquit_handler)
 
-    # Non-callable is not
-    with pytest.raises(ValueError):
-        on_sigquit('non-callable')
+        # Non-callable is not
+        with pytest.raises(ValueError):
+            on_sigquit('non-callable')
 
-    # TODO(jacobperron): implement a functional test by using subprocess.Popen
+        # TODO(jacobperron): implement a functional test by using subprocess.Popen
 
 
 def test_on_sigterm():
     """Test the on_sigterm() function."""
-    # None is acceptable
-    on_sigterm(None)
+    with pytest.deprecated_call():
+        # None is acceptable
+        on_sigterm(None)
 
-    def mock_sigterm_handler():
-        pass
+        def mock_sigterm_handler():
+            pass
 
-    on_sigterm(mock_sigterm_handler)
+        on_sigterm(mock_sigterm_handler)
 
-    # Non-callable is not
-    with pytest.raises(ValueError):
-        on_sigterm('non-callable')
+        # Non-callable is not
+        with pytest.raises(ValueError):
+            on_sigterm('non-callable')
 
-    # TODO(jacobperron): implement a functional test by using subprocess.Popen
+        # TODO(jacobperron): implement a functional test by using subprocess.Popen