Apply suggestions from code review

alexmaclean6 · ahcorde · web-flow · commit a7281580bbfd · 2025-11-13T08:03:26.000-05:00
Co-authored-by: Alejandro Hernández Cordero &lt;ahcorde@gmail.com&gt;
Signed-off-by: Alex MacLean &lt;alex@macleanfam.org&gt;
diff --git a/test/test_logging_severity_with_color.cpp b/test/test_logging_severity_with_color.cpp
@@ -22,13 +22,13 @@ int main(int, char **)
 {
   rcutils_ret_t ret = rcutils_logging_initialize();
   if (ret != RCUTILS_RET_OK) {
-    fprintf(stderr, "error initializing logging: %s\n", rcutils_get_error_string().str);
+    std::cerr << "error initializing logging: " << rcutils_get_error_string().str << std::endl;
     return -1;
   }
 
   rcutils_ret_t status = rcutils_logging_set_logger_level("name", RCUTILS_LOG_SEVERITY_DEBUG);
   if (status != RCUTILS_RET_OK) {
-    fprintf(stderr, "error setting logger level: %s\n", rcutils_get_error_string().str);
+    std::cerr << "error setting logger level: " << rcutils_get_error_string().str << std::endl;
     return -1;
   }
 
diff --git a/test/test_logging_severity_with_color.py b/test/test_logging_severity_with_color.py
@@ -1,4 +1,4 @@
-# Copyright 2017 Open Source Robotics Foundation, Inc.
+# Copyright 2025 Open Source Robotics Foundation, Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

Original file line number	Diff line number	Diff line change
`@@ -22,13 +22,13 @@ int main(int, char **)`
`22`	`22`	`{`
`23`	`23`	`rcutils_ret_t ret = rcutils_logging_initialize();`
`24`	`24`	`if (ret != RCUTILS_RET_OK) {`
`25`		`- fprintf(stderr, "error initializing logging: %s\n", rcutils_get_error_string().str);`
	`25`	`+ std::cerr << "error initializing logging: " << rcutils_get_error_string().str << std::endl;`
`26`	`26`	`return -1;`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`rcutils_ret_t status = rcutils_logging_set_logger_level("name", RCUTILS_LOG_SEVERITY_DEBUG);`
`30`	`30`	`if (status != RCUTILS_RET_OK) {`
`31`		`- fprintf(stderr, "error setting logger level: %s\n", rcutils_get_error_string().str);`
	`31`	`+ std::cerr << "error setting logger level: " << rcutils_get_error_string().str << std::endl;`
`32`	`32`	`return -1;`
`33`	`33`	`}`
`34`	`34`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# Copyright 2017 Open Source Robotics Foundation, Inc.`
	`1`	`+# Copyright 2025 Open Source Robotics Foundation, Inc.`
`2`	`2`	`#`
`3`	`3`	`# Licensed under the Apache License, Version 2.0 (the "License");`
`4`	`4`	`# you may not use this file except in compliance with the License.`