Removes erroneous unmatched closing parenthesis (#125)

* Removes erroneous unmatched closing parenthesis

Signed-off-by: Charles Cross <charles@missionrobotics.us>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

Author: spiderkeys

rosidl_generator_py/CMakeLists.txt

@@ -56,6 +56,7 @@ if(BUILD_TESTING)
     rosidl_generate_interfaces(${PROJECT_NAME}_custom
       ${test_interface_files_MSG_FILES}
       # Cases not covered by test_interface_files
+      msg/BuiltinTypeSequencesIdl.idl
       msg/StringArrays.msg
       msg/Property.msg
       ADD_LINTER_TESTS

rosidl_generator_py/msg/BuiltinTypeSequencesIdl.idl

@@ -0,0 +1,8 @@
+module rosidl_generator_py {
+    module msg {
+        struct BuiltinTypeSequencesIdl {
+            // Unbounded sequences
+            sequence<char> char_sequence_unbounded;
+        };
+    };
+};

rosidl_generator_py/resource/_msg.py.em

@@ -498,7 +498,7 @@ bound = 2**nbits
                  all(val >= 0 and val < @(bound) for val in value)), \
 @{assert_msg_suffixes.append('and each unsigned integer in [0, %d]' % (bound - 1))}@
 @[    elif isinstance(type_, BasicType) and type_.typename == 'char']@
-                 all(val >= 0 and val) < 256 for val in value)), \
+                 all(ord(val) >= 0 and ord(val) < 256 for val in value)), \
 @{assert_msg_suffixes.append('and each char in [0, 255]')}@
 @[    elif isinstance(type_, BasicType) and type_.typename in FLOATING_POINT_TYPES]@
 @[      if type_.typename == "float"]@

rosidl_generator_py/test/test_interfaces.py

@@ -20,6 +20,7 @@
 from rosidl_generator_py.msg import Arrays
 from rosidl_generator_py.msg import BasicTypes
 from rosidl_generator_py.msg import BoundedSequences
+from rosidl_generator_py.msg import BuiltinTypeSequencesIdl
 from rosidl_generator_py.msg import Constants
 from rosidl_generator_py.msg import Defaults
 from rosidl_generator_py.msg import Nested
@@ -916,3 +917,12 @@ def test_string_slot_types():
     assert isinstance(string_slot_types[4], Array)
     assert isinstance(string_slot_types[4].value_type, UnboundedString)
     assert string_slot_types[4].size == 3
+
+
+def test_builtin_sequence_slot_attributes():
+    msg = BuiltinTypeSequencesIdl()
+    assert hasattr(msg, 'get_fields_and_field_types')
+    assert hasattr(msg, '__slots__')
+    builtin_sequence_slot_types_dict = getattr(msg, 'get_fields_and_field_types')()
+    builtin_sequence_slots = getattr(msg, '__slots__')
+    assert len(builtin_sequence_slot_types_dict) == len(builtin_sequence_slots)