Skip to content

Commit e4c419f

Browse files
Remove NoReturn for now (#229)
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
1 parent 0a09413 commit e4c419f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

rosidl_generator_py/resource/_action.py.em

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,6 @@ class @(action.namespaced_type.name)(metaclass=Metaclass_@(action.namespaced_typ
102102
# The generic message for get the status of a goal.
103103
from action_msgs.msg._goal_status_array import GoalStatusArray as GoalStatusMessage
104104

105-
# type ignore below fixed in mypy 1.0+ see mypy#10342
106-
def __init__(self) -> typing.NoReturn: # type: ignore
105+
# Should eventually be typing.NoReturn. See mypy#14044
106+
def __init__(self) -> None:
107107
raise NotImplementedError('Action classes can not be instantiated')

rosidl_generator_py/resource/_srv.py.em

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,6 @@ class @(service.namespaced_type.name)(metaclass=Metaclass_@(service.namespaced_t
6161
from @('.'.join(service.namespaced_type.namespaces)).@(module_name) import @(service.response_message.structure.namespaced_type.name) as Response
6262
from @('.'.join(service.namespaced_type.namespaces)).@(module_name) import @(service.event_message.structure.namespaced_type.name) as Event
6363

64-
# type ignore below fixed in mypy 1.0+ see mypy#10342
65-
def __init__(self) -> typing.NoReturn: # type: ignore
64+
# Should eventually be typing.NoReturn. See mypy#14044
65+
def __init__(self) -> None:
6666
raise NotImplementedError('Service classes can not be instantiated')

0 commit comments

Comments
 (0)