[Bug] Convert::getDestination returns incorrect destination in multisite

[tcharbonnier-gp-aviva]

Hello,
I discovered the function Convert::getDestination doesn't return the correct WEBP path for an image path when WordPress is setup in multisite mode.

If I use the filename /home/test/public_html/wp-content/uploads/sites/4/2024/12/14195972_10153736783536286_2796225845147856050_o.jpg, this function will return /home/test/public_html/wp-content/webp-express/webp-images/uploads/2024/12/14195972_10153736783536286_2796225845147856050_o.jpg.webp which is incorrect because it should be /home/test/public_html/wp-content/webp-express/webp-images/uploads/sites/4/2024/12/14195972_10153736783536286_2796225845147856050_o.jpg.webp.

The difference is the sites/(site_id) part which is missing in the current function return value.

[tcharbonnier-gp-aviva]

Apparently, this problem only occurs when WordPress is loaded: I discovered it because of the wp_delete_file hook : files were not deleted. But files are created correctly using WebPOnDemand.php

The problem lies somewhere between class ImageRoots or method getDestination of lib/classes/ConvertHelperIndependant.php:

Indeed, if I look at ImageRoots instance, I get this:

object(WebPExpress\ImageRoots)#5689 (2) {
  ["imageRootsDef":"WebPExpress\ImageRoots":private]=>
  array(5) {
    [0]=>
    array(3) {
      ["id"]=>
      string(7) "uploads"
      ["rel-path"]=>
      string(26) "wp-content/uploads/sites/4"
      ["url"]=>
      string(57) "https://www.test.com/wp-content/uploads/sites/4"
    }
  }
  ["imageRoots":"WebPExpress\ImageRoots":private]=>
  array(5) {
    [0]=>
    object(WebPExpress\ImageRoot)#5688 (2) {
      ["id"]=>
      string(7) "uploads"
      ["imageRootDef":"WebPExpress\ImageRoot":private]=>
      array(3) {
        ["id"]=>
        string(7) "uploads"
        ["rel-path"]=>
        string(26) "wp-content/uploads/sites/4"
        ["url"]=>
        string(57) "https://www.test.com/wp-content/uploads/sites/4"
      }
    }

But, in getDestination, $destination is defined as $destination = $webExpressContentDirAbs . '/webp-images/' . $imageRoot->id . '/' . $relPath;; So either $relPath is incorrect or $imageRoot->id should return uploads/sites/4 instead of just uplaods. I think it's $relPath that is incorrect. $relPath removes $rootPath from $sourceResolved using substr so removes the sites/4 part.

$sourceResolved = "/home/test/public_html/wp-content/uploads/sites/4/2024/12/14195972_10153736783536286_2796225845147856050_o.jpg"
$rootPath = "/home/test/public_html/wp-content/uploads/sites/4"

$relPath = "2024/12/14195972_10153736783536286_2796225845147856050_o.jpg.webp"
$destination = "/home/test/public_html/wp-content/webp-express/webp-images/uploads/2024/12/14195972_10153736783536286_2796225845147856050_o.jpg.webp"