-
Notifications
You must be signed in to change notification settings - Fork 355
Open
Labels
breaking changesChanges that break API or behaviourChanges that break API or behaviournew APIrefactoringsChanges that does not affect API and behaviourChanges that does not affect API and behaviour
Milestone
Description
Payload API has inconsistent and absolutely confusing behavior:
##Expected
case 1
var p = ByteBufPayload.create(data, Unpooled.EMPTY)
assertTrue(p.hasMetadata())
assertEqueals(p.metadata(), Unpooled.EMPTY)
Unexpected
case 2
var p = ByteBufPayload.create(data, null)
assertFalse(p.hasMetadata())
assertNull(p.metadata()) // fails because Payload always returns Unpooled.EMPTY
Metadata
Metadata
Assignees
Labels
breaking changesChanges that break API or behaviourChanges that break API or behaviournew APIrefactoringsChanges that does not affect API and behaviourChanges that does not affect API and behaviour