Skip to content

Commit 29754e0

Browse files
committed
fix: simplify Option convert
1 parent 6c15dfb commit 29754e0

File tree

18 files changed

+33
-111
lines changed

18 files changed

+33
-111
lines changed

rsocket-transport-tcp/src/connection/tcp.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,10 @@ impl Writer for InnerWriter {
3434
#[async_trait]
3535
impl Reader for InnerReader {
3636
async fn read(&mut self) -> Option<Result<Frame>> {
37-
match self.stream.next().await {
38-
Some(Ok(frame)) => Some(Ok(frame)),
39-
Some(Err(e)) => Some(Err(RSocketError::IO(e).into())),
40-
None => None,
41-
}
37+
self.stream
38+
.next()
39+
.await
40+
.map(|next| next.map_err(|e| RSocketError::IO(e).into()))
4241
}
4342
}
4443

rsocket-transport-tcp/src/connection/uds.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,10 @@ impl Writer for InnerWriter {
4949
#[async_trait]
5050
impl Reader for InnerReader {
5151
async fn read(&mut self) -> Option<Result<Frame>> {
52-
match self.stream.next().await {
53-
Some(Ok(frame)) => Some(Ok(frame)),
54-
Some(Err(e)) => Some(Err(RSocketError::IO(e).into())),
55-
None => None,
56-
}
52+
self.stream
53+
.next()
54+
.await
55+
.map(|it| it.map_err(|e| RSocketError::IO(e).into()))
5756
}
5857
}
5958

rsocket-transport-wasm/src/connection.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,7 @@ impl Writer for InnerWriter {
3737
#[async_trait]
3838
impl Reader for InnerReader {
3939
async fn read(&mut self) -> Option<Result<Frame>> {
40-
match self.rx.next().await {
41-
Some(frame) => Some(Ok(frame)),
42-
None => None,
43-
}
40+
self.rx.next().await.map(|frame| Ok(frame))
4441
}
4542
}
4643

rsocket-transport-wasm/src/misc.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,7 @@ fn to_vec(input: JsValue) -> Option<Vec<u8>> {
9898
if input.is_null() || input.is_undefined() {
9999
None
100100
} else if input.is_string() {
101-
match input.as_string() {
102-
Some(s) => Some(s.into_bytes()),
103-
None => None,
104-
}
101+
input.as_string().map(|s| s.into_bytes())
105102
} else {
106103
Some(Uint8Array::from(input).to_vec())
107104
}

rsocket/src/core/client.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,10 +120,7 @@ where
120120
let mut socket = DuplexSocket::new(1, snd_tx, splitter).await;
121121

122122
let mut cloned_socket = socket.clone();
123-
let acceptor: Option<Acceptor> = match self.responder {
124-
Some(it) => Some(Acceptor::Simple(Arc::new(it))),
125-
None => None,
126-
};
123+
let acceptor: Option<Acceptor> = self.responder.map(|it| Acceptor::Simple(Arc::new(it)));
127124

128125
let conn = tp.connect().await?;
129126
let (mut sink, mut stream) = conn.split();

rsocket/src/core/server.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,7 @@ where
6565

6666
pub async fn serve(mut self) -> Result<()> {
6767
let mut server_transport = self.transport.take().expect("missing transport");
68-
69-
let acceptor = match self.on_setup {
70-
Some(v) => Some(Acceptor::Generate(Arc::new(v))),
71-
None => None,
72-
};
68+
let acceptor = self.on_setup.map(|v| Acceptor::Generate(Arc::new(v)));
7369

7470
let mtu = self.mtu;
7571

rsocket/src/frame/error.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,7 @@ impl Error {
7070
}
7171

7272
pub fn get_data(&self) -> Option<&Bytes> {
73-
match &self.data {
74-
Some(b) => Some(b),
75-
None => None,
76-
}
73+
self.data.as_ref()
7774
}
7875

7976
pub fn get_code(&self) -> u32 {

rsocket/src/frame/keepalive.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,7 @@ impl Keepalive {
6868
}
6969

7070
pub fn get_data(&self) -> Option<&Bytes> {
71-
match &self.data {
72-
Some(b) => Some(b),
73-
None => None,
74-
}
71+
self.data.as_ref()
7572
}
7673

7774
pub fn split(self) -> (Option<Bytes>, Option<Bytes>) {

rsocket/src/frame/lease.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,7 @@ impl Lease {
7878
}
7979

8080
pub fn get_metadata(&self) -> Option<&Bytes> {
81-
match &self.metadata {
82-
Some(b) => Some(b),
83-
None => None,
84-
}
81+
self.metadata.as_ref()
8582
}
8683

8784
pub fn get_ttl(&self) -> u32 {

rsocket/src/frame/metadata_push.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,7 @@ impl MetadataPush {
4444
}
4545

4646
pub fn get_metadata(&self) -> Option<&Bytes> {
47-
match &self.metadata {
48-
Some(b) => Some(b),
49-
None => None,
50-
}
47+
self.metadata.as_ref()
5148
}
5249

5350
pub fn split(self) -> (Option<Bytes>, Option<Bytes>) {

0 commit comments

Comments
 (0)