Fix file replacement on activity

Author: dharmin

admin/rt-transcoder-handler.php

@@ -672,7 +672,7 @@ public function usage_widget() {
 	 * @return url
 	 */
 	public function add_media_thumbnails( $post_array ) {
-
+g
 		$defaults = array(
 	 		'post_id' 	=> '',
 	 		'job_for' 	=> '',
@@ -836,6 +836,7 @@ public function add_transcoded_files( $file_post_array, $attachment_id, $job_for
 							$download_url                   = urldecode( urldecode( $file ) );
 							$new_wp_attached_file_pathinfo 	= pathinfo( $download_url );
 							$post_mime_type                	= 'mp4' === $new_wp_attached_file_pathinfo['extension'] ? 'video/mp4' : 'audio/mp3';
+							$attachemnt_url  	            = wp_get_attachment_url( $attachment_id );
 							try {
 								$response = function_exists( 'vip_safe_wp_remote_get' ) ? vip_safe_wp_remote_get( $download_url ) : wp_remote_get( $download_url ); // @codingStandardsIgnoreLine
 							} catch ( Exception $e ) {
@@ -907,7 +908,6 @@ public function add_transcoded_files( $file_post_array, $attachment_id, $job_for
 					if ( 'rtmedia' === $job_for ) {
 						$activity_id = $media[0]->activity_id;
 						if ( $activity_id ) {
-							$attachemnt_url  	= wp_get_attachment_url( $attachment_id );
 							$content          	= $wpdb->get_var( $wpdb->prepare( "SELECT content FROM {$wpdb->base_prefix}bp_activity WHERE id = %d", $activity_id ) );
 
 							/* for WordPress backward compatibility */