Add callback to go back to previous page instead inline JS

dhaval-parekh · dhaval-parekh · commit f3aece85cf76 · 2020-05-14T14:26:45.000+05:30
diff --git a/admin/rt-retranscode-admin.php b/admin/rt-retranscode-admin.php
@@ -521,7 +521,11 @@ function RetranscodeMediaFinishUp() {
 				}
 				$("#message").html("<p><strong>" + rt_resulttext + "</strong></p>");
 				$("#message").show();
-				$( '#retranscode-goback' ).attr( 'href', 'javascript:history.go(-1)' );
+
+				$( '#retranscode-goback' ).on( 'click', function () {
+					window.history.go( -1 );
+				} );
+
 			}
 			<?php
 				// translators: Media ID.

Original file line number	Diff line number	Diff line change
`@@ -521,7 +521,11 @@ function RetranscodeMediaFinishUp() {`
`521`	`521`	`}`
`522`	`522`	`$("#message").html("<p><strong>" + rt_resulttext + "</strong></p>");`
`523`	`523`	`$("#message").show();`
`524`		`- $( '#retranscode-goback' ).attr( 'href', 'javascript:history.go(-1)' );`
	`524`	`+`
	`525`	`+ $( '#retranscode-goback' ).on( 'click', function () {`
	`526`	`+ window.history.go( -1 );`
	`527`	`+ } );`
	`528`	`+`
`525`	`529`	`}`
`526`	`530`	`<?php`
`527`	`531`	`// translators: Media ID.`