Skip to content
This repository was archived by the owner on Aug 22, 2025. It is now read-only.

Conversation

@Pathan-Amaankhan
Copy link
Member

@Pathan-Amaankhan Pathan-Amaankhan commented Mar 9, 2023

Description

  • This PR updates conditional check for mp3 files.

Requirement

  • The default post_mime_type for .m4a files is audio/mpeg(The same is for .mp3 files), so our condition was failing.

Screenshot 2023-03-09 at 6 48 52 PM

  • Whenever we transcode any audio file, file is converted to mp3 & attachment is updated in wp_postmeta but in wp_posts, we are still having post_mime_type of the old media file.

Screenshot 2023-03-16 at 3 58 38 PM

Screenshot 2023-03-16 at 4 00 33 PM

Fixes/Covers

@Pathan-Amaankhan Pathan-Amaankhan marked this pull request as ready for review March 10, 2023 09:45
@Pathan-Amaankhan Pathan-Amaankhan changed the title GH-246: Issue with transcoding the previously uploaded .m4a files [Develop] GH-246/GH-247: Issue with transcoding the previously uploaded .m4a/.mp3 files [Develop] Mar 16, 2023
@Pathan-Amaankhan Pathan-Amaankhan changed the title GH-246/GH-247: Issue with transcoding the previously uploaded .m4a/.mp3 files [Develop] GH-246/GH-247: Issue with transcoding the previously uploaded audio files [Develop] Mar 16, 2023
An error occurred while trying to automatically change base from develop to master October 19, 2023 11:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants