Skip to content
This repository was archived by the owner on Aug 22, 2025. It is now read-only.

Conversation

@pranvinit
Copy link

@pranvinit pranvinit commented Nov 6, 2024

Types of changes

What types of changes does your code introduced to project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Details

  1. Create a new /transcoder-callback REST API endpoint to handle the response of the FFMPEG transcoding server.
  2. Does not change the existing callback_handler function implementation.

Checklist

Put an x in the boxes that apply.

  • Lint and tests pass locally with my changes
  • I have added necessary documentation (if appropriate)

Closing issues

Copy link
Contributor

@rtBot rtBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis identified issues

action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

⚠️ 6 warnings


Powered by rtCamp's GitHub Actions Library

@pranvinit pranvinit requested a review from elifvish November 6, 2024 06:28
Copy link
Contributor

@rtBot rtBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis identified issues

action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

🚫 3 errors

⚠️ 3 warnings


Powered by rtCamp's GitHub Actions Library

Copy link
Contributor

@rtBot rtBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis identified issues

action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

⚠️ 13 warnings


Powered by rtCamp's GitHub Actions Library

Posting will continue in further review(s)

Copy link
Contributor

@rtBot rtBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous scan continued.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants