Do not allow running jobs with OneOnOne on executors which may averflow

Author: pitr-ch

lib/concurrent/executor/executor.rb

@@ -4,6 +4,9 @@
 module Concurrent
 
   module Executor
+    def can_overflow?
+      false
+    end
   end
 
   module RubyExecutor

lib/concurrent/executor/java_thread_pool_executor.rb

@@ -89,6 +89,10 @@ def initialize(opts = {})
         set_shutdown_hook
       end
 
+      def can_overflow?
+        @max_queue != 0
+      end
+
       # The minimum number of threads that may be retained in the pool.
       #
       # @return [Integer] the min_length

lib/concurrent/executor/one_by_one.rb

@@ -30,6 +30,10 @@ def initialize
     # @raise [ArgumentError] if no task is given
     def post(executor, *args, &task)
       return nil if task.nil?
+      if executor.can_overflow?
+        raise ArgumentError, 'OneByOne cannot be used in conjunction with executor which may overflow'
+      end
+
       job = Job.new executor, args, task
 
       begin

lib/concurrent/executor/ruby_thread_pool_executor.rb

@@ -99,6 +99,10 @@ def initialize(opts = {})
       @last_gc_time = Time.now.to_f - [1.0, (@gc_interval * 2.0)].max
     end
 
+    def can_overflow?
+      @max_queue != 0
+    end
+
     # The number of threads currently in the pool.
     #
     # @return [Integer] the length