Moved thread pool tests from shared to ruby-specific.

The specs for the Java-specific thread pools are mainly intended to
1) ensure consistent APIs and 2) verify that the Ruby thread pools
have matching behavior. Some of the more complex behaviors (such
as thread creation and garbage collection) are difficult to test
for the Java thread pools. In these cases we'll just trust that
Java's thread pools behave as documented and just test the Ruby
versions.

Author: jdantonio

spec/concurrent/cached_thread_pool_shared.rb

@@ -104,51 +104,10 @@
     end
   end
 
-  context 'garbage collection' do
-
-    subject{ described_class.new(idletime: 1, max_threads: 5, gc_interval: 0) }
-
-    it 'removes from pool any thread that has been idle too long' do
-      3.times { subject << proc{ sleep(0.1) } }
-      sleep(0.1)
-      subject.length.should eq 3
-      sleep(2)
-      subject << proc{ nil }
-      sleep(0.1)
-      subject.length.should < 3
-    end
-
-    it 'removes from pool any dead thread' do
-      3.times { subject << proc{ sleep(0.1); raise Exception } }
-      sleep(0.1)
-      subject.length.should eq 3
-      sleep(2)
-      subject << proc{ nil }
-      sleep(0.1)
-      subject.length.should < 3
-    end
-  end
-
   context 'worker creation and caching' do
 
     subject{ described_class.new(idletime: 1, max_threads: 5) }
 
-    it 'creates new workers when there are none available' do
-      subject.length.should eq 0
-      5.times{ sleep(0.1); subject << proc{ sleep(1) } }
-      sleep(1)
-      subject.length.should eq 5
-    end
-
-    it 'uses existing idle threads' do
-      5.times{ subject << proc{ sleep(0.1) } }
-      sleep(1)
-      subject.length.should >= 5
-      3.times{ subject << proc{ sleep(1) } }
-      sleep(0.1)
-      subject.length.should >= 5
-    end
-
     it 'never creates more than :max_threads threads' do
       pool = described_class.new(max_threads: 5)
       100.times{ pool << proc{ sleep(1) } }

spec/concurrent/fixed_thread_pool_shared.rb

@@ -115,27 +115,8 @@
     end
   end
 
-  context 'exception handling' do
-
-    it 'restarts threads that experience exception' do
-      count = subject.length
-      count.times{ subject << proc{ raise StandardError } }
-      sleep(1)
-      subject.length.should eq count
-    end
-  end
-
   context 'worker creation and caching' do
 
-    it 'creates new workers when there are none available' do
-      pool = described_class.new(5)
-      pool.current_length.should eq 0
-      5.times{ pool << proc{ sleep(1) } }
-      sleep(0.1)
-      pool.current_length.should eq 5
-      pool.kill
-    end
-
     it 'never creates more than :num_threads threads' do
       pool = described_class.new(5)
       100.times{ pool << proc{ sleep(1) } }

spec/concurrent/ruby_cached_thread_pool_spec.rb

@@ -13,5 +13,51 @@ module Concurrent
     end
 
     it_should_behave_like :cached_thread_pool
+
+    context 'garbage collection' do
+
+      subject{ described_class.new(idletime: 1, max_threads: 5, gc_interval: 0) }
+
+      it 'removes from pool any thread that has been idle too long' do
+        3.times { subject << proc{ sleep(0.1) } }
+        sleep(0.1)
+        subject.length.should eq 3
+        sleep(2)
+        subject << proc{ nil }
+        sleep(0.1)
+        subject.length.should < 3
+      end
+
+      it 'removes from pool any dead thread' do
+        3.times { subject << proc{ sleep(0.1); raise Exception } }
+        sleep(0.1)
+        subject.length.should eq 3
+        sleep(2)
+        subject << proc{ nil }
+        sleep(0.1)
+        subject.length.should < 3
+      end
+    end
+
+    context 'worker creation and caching' do
+
+      subject{ described_class.new(idletime: 1, max_threads: 5) }
+
+      it 'creates new workers when there are none available' do
+        subject.length.should eq 0
+        5.times{ sleep(0.1); subject << proc{ sleep(1) } }
+        sleep(1)
+        subject.length.should eq 5
+      end
+
+      it 'uses existing idle threads' do
+        5.times{ subject << proc{ sleep(0.1) } }
+        sleep(1)
+        subject.length.should >= 5
+        3.times{ subject << proc{ sleep(1) } }
+        sleep(0.1)
+        subject.length.should >= 5
+      end
+    end
   end
 end

spec/concurrent/ruby_fixed_thread_pool_spec.rb

@@ -13,5 +13,27 @@ module Concurrent
     end
 
     it_should_behave_like :fixed_thread_pool
+
+    context 'exception handling' do
+
+      it 'restarts threads that experience exception' do
+        count = subject.length
+        count.times{ subject << proc{ raise StandardError } }
+        sleep(1)
+        subject.length.should eq count
+      end
+    end
+
+    context 'worker creation and caching' do
+
+      it 'creates new workers when there are none available' do
+        pool = described_class.new(5)
+        pool.current_length.should eq 0
+        5.times{ pool << proc{ sleep(1) } }
+        sleep(0.1)
+        pool.current_length.should eq 5
+        pool.kill
+      end
+    end
   end
 end